Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made functions void where their return values were never used #14582

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alexknop
Copy link
Collaborator

Problem:
There were functions that were declared to return values, but when used in the project, there was no use of the return values.

Solution:
Change these functions to void for now.

Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14582.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

Copy link

Codacy

Lint

TypemasterPR
Warnings5454
Errors33

SpotBugs

CategoryBaseNew
Bad practice6565
Correctness5858
Dodgy code294295
Experimental11
Internationalization77
Malicious code vulnerability11
Multithreaded correctness77
Performance5151
Security1818
Total502503

SpotBugs increased!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants