Enable MariaDB binary log

[meonkeys]

This resolves a warning in the database server log:

[Warning] You need to use --log-bin to make --binlog-format work.

Pros:

• support for point-in-time recovery
• necessary for replication

Cons:

• slows down database operations ("slightly", per the manual)
• takes up disk space (mitigated by --expire-logs-days=2)

See also:

• https://mariadb.com/kb/en/binary-log/
• https://mariadb.com/kb/en/full-list-of-mariadb-options-system-and-status-variables/

Alternatives:

1. Do not add --log-bin. Remove --binlog-format instead. This causes the least amount of change for existing installations.

Signed-off-by: Adam Monsen [email protected]

[J0WI]

We use the recommend parameters from here:

• https://docs.nextcloud.com/server/25/admin_manual/installation/system_requirements.html#database-requirements-for-mysql-mariadb
• https://docs.nextcloud.com/server/25/admin_manual/configuration_database/linux_database_configuration.html#configuring-a-mysql-or-mariadb-database

Are you familiar with those parameters? I wonder if this would also affect everyone else using MariaDB/MySQL. If so, this should probably be discussed in the upstream documentation:

• https://github.com/nextcloud/documentation/blob/master/admin_manual/installation/system_requirements.rst#database-requirements-for-mysql--mariadb
• https://github.com/nextcloud/documentation/blob/master/admin_manual/configuration_database/linux_database_configuration.rst#configuring-a-mysql-or-mariadb-database

[meonkeys]

Thank you, I reviewed those sections of documentation. The first one recommends either using a row-level binary log or disabling the binary log. The second one (with the example my.cnf) indicates use of a row-level binary log.

My patch is mostly coherent with the documentation, and it fixes the MariaDB warning. I anticipate the impact of the change will be minimal and positive.

To better align with recommendations in the Nextcloud documentation, I'll remove --expire-logs-days=2. This isn't necessary. The MySQL and MariaDB documentation both state that binary logs will be purged on startup and flush/rotation anyway.