Add --target-branch
to linting and install helm chart GHA steps, and remove deprecated input param from kind step
#387
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description of the change
Updates
ct
commands in both the linting and installing steps to now use the param for target branch:--target-branch ${{ github.event.repository.default_branch }}
Also removes
install_local_path_provisioner
param from kind action, which was causing warnings.Benefits
now we match the example in the readme here:
https://github.com/helm/chart-testing-action
Without it, it was causing these issues:
https://github.com/nextcloud/helm/actions/runs/4787913488/jobs/8513797467
also prevents this warning:
Possible drawbacks
can't tell if we need the ct.yml anymore 🤷
Applicable issues
No issues yet 😅 Just caught this while testing something else.
Additional information
You can see the testing I did here:
https://github.com/nextcloud/helm/actions/runs/4787957878/jobs/8513900880
Checklist
Chart.yaml
according to semver.