Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle 204 response #10728

Merged
merged 1 commit into from
Feb 20, 2025
Merged

fix: handle 204 response #10728

merged 1 commit into from
Feb 20, 2025

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented Feb 20, 2025

Follow-up for #10694

  • A 404 is no longer an expected response, so the special handling has been removed.
  • A 204 response has an empty body, which means avatar.url would return undefined. This update makes it more explicit what is happening and what’s expected, though the behavior itself remains unchanged.

@kesselb
fix: handle 204 response
0014941 
Signed-off-by: Daniel Kesselberg <[email protected]>
@kesselb kesselb self-assigned this Feb 20, 2025
@kesselb kesselb modified the milestone: v4.2.0 Feb 20, 2025
@kesselb
Copy link
Contributor Author

kesselb commented Feb 20, 2025

/backport to stable4.2

ChristophWurst
ChristophWurst approved these changes Feb 20, 2025
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was actually surprised for this to work without frontend modifications in the original PR 🙈

@kesselb
Copy link
Contributor Author

kesselb commented Feb 20, 2025

I was actually surprised for this to work without frontend modifications in the original PR 🙈

It does work as expected even without this change. Coincidentally, the expected return for 404 response was undefined and "".url is also undefined 🤣

@kesselb kesselb merged commit cc97a50 into main Feb 20, 2025
34 checks passed
@kesselb kesselb deleted the bug/noid/handle-204-response branch February 20, 2025 11:52
@kesselb
Copy link
Contributor Author

kesselb commented Feb 20, 2025

/backport to stable4.1

@kesselb
Copy link
Contributor Author

kesselb commented Feb 20, 2025

/backport to stable3.7

This was referenced Feb 20, 2025
Merged
Merged
@backportbot backportbot bot mentioned this pull request Feb 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@GretaD GretaD Awaiting requested review from GretaD GretaD is a code owner

Assignees

@kesselb kesselb

Labels
3. to review bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kesselb @ChristophWurst