v2 API (Folders)

[powerpaul17]

This should be the folder part of the v2 API.

[SMillerDev]

Thanks for the PR, it's exciting that someone is getting started with the V2 API 4,5 years after the draft was written 😅.

I would ask/urge you to split the work into multiple pull requests though. It's simply too much work to review it otherwise. If you add some test to the current one it's perfectly doable to review it and I'd be happy to do so.

[powerpaul17]

Thanks for the excitement! 😉 It will certainly take some time as I'm doing this also in my spare time. But I guess people are used to being patient around here..
From what I saw the draft should be ok, as stated in the issue #628 there may come up some things to change but I think it would be best to deal with it in the process. We can always discuss them when it becomes relevant.
I totally agree that having too big PRs is very hard to review, so I'll try to submit in pieces.

[powerpaul17]

@SMillerDev, one question: I saw that you recently added the v2 versions of the services and mappers. I suppose I should use these since the others are marked as deprecated. But there are now some functions missing which were available before. Should I recreate these according to the old ones? Are there any other things to keep in mind?

[anoymouserver]

Yes you should use the V2 versions of the mappers/services, since the old ones are removed gradually.
One option is that you list which functions are missing for APIv2 and we implement them, or you implement them yourself and we review it then anyways.

[powerpaul17]

Yes you should use the V2 versions of the mappers/services, since the old ones are removed gradually.
One option is that you list which functions are missing for APIv2 and we implement them, or you implement them yourself and we review it then anyways.

I have no problem in implementing what I need, just wanted to make sure it's ok since it's my first time contributing to this repo. But I guess I'm too polite, we can sort everything out during/after the review(s) 😉

[SMillerDev]

Looking good so far, just some comments that could make the code cleaner IMHO

[powerpaul17]

Thanks for reviewing already but actually I'm not finished yet.. 😅 But it's definitely good to have some feedback..

[SMillerDev]

Just wanted to get some basic review done already. Don't forget to rebase when you continue because I just merged the V2 version of the Feed Services.

[SMillerDev]

Thanks for the work, the code itself looks mostly fine in terms of features now. I'd just like some more consistent type usage and more tests and then we'll be good to go.

[powerpaul17]

Thanks, I am always in favor of type hints & tests, I just do not program a lot in php, so I didn't know how to do it..

[SMillerDev]

Just a couple more tweaks and I think we're ready to go after.

[codecov-io]

Codecov Report

Merging #1003 (cdf18fa) into master (aaa461d) will decrease coverage by 0.52%.
The diff coverage is 91.78%.

@@             Coverage Diff              @@
##             master    #1003      +/-   ##
============================================
- Coverage     87.22%   86.69%   -0.53%     
- Complexity      701      726      +25     
============================================
  Files            60       62       +2     
  Lines          2520     2609      +89     
============================================
+ Hits           2198     2262      +64     
- Misses          322      347      +25     

Impacted Files	Coverage Δ	Complexity Δ
lib/Controller/ApiController.php	72.72% <0.00%> (ø)	5.00 <0.00> (ø)
lib/Controller/ApiPayloadTrait.php	68.42% <44.44%> (-21.58%)	9.00 <4.00> (+4.00)	⬇️
lib/Controller/FolderApiV2Controller.php	100.00% <100.00%> (ø)	8.00 <8.00> (?)
lib/Db/Feed.php	99.05% <100.00%> (+0.06%)	78.00 <3.00> (+3.00)
lib/Db/Folder.php	100.00% <100.00%> (ø)	22.00 <1.00> (+1.00)
lib/Db/Item.php	100.00% <100.00%> (ø)	83.00 <2.00> (+2.00)
lib/Fetcher/FeedFetcher.php	88.57% <0.00%> (-0.17%)	37.00% <0.00%> (ø%)
lib/Config/LegacyConfig.php	0.00% <0.00%> (ø)	7.00% <0.00%> (ø%)
lib/Service/FeedServiceV2.php	100.00% <0.00%> (ø)	28.00% <0.00%> (ø%)
lib/Service/ImportService.php	100.00% <0.00%> (ø)	6.00% <0.00%> (ø%)
... and 8 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aaa461d...cdf18fa. Read the comment docs.

[SMillerDev]

Looks good to me but I'd like to hold of on merging this until we have 15.4 shipped, shouldn't be too long now.

[powerpaul17]

No problem, I just wanted to make sure if it's ok now, so I can continue with the next part. 😉