Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redis cluster support #4061

Merged
merged 3 commits into from
Apr 26, 2017
Merged

Redis cluster support #4061

merged 3 commits into from
Apr 26, 2017

Conversation

MorrisJobke
Copy link
Member

@MorrisJobke MorrisJobke commented Mar 26, 2017 •
edited
Loading

Notes:

Fixes #2317

RobinMcCorkell and others added 3 commits March 25, 2017 21:25
@RobinMcCorkell @MorrisJobke
Add Redis Cluster support
ef57c03 
Signed-off-by: Morris Jobke <[email protected]>
@butonic @MorrisJobke
fix constant
3d0005d 
Signed-off-by: Morris Jobke <[email protected]>
@butonic @MorrisJobke
no ternary
5da8456 
Signed-off-by: Morris Jobke <[email protected]>
@MorrisJobke MorrisJobke added 3. to review Waiting for reviews downstream labels Mar 26, 2017
@MorrisJobke MorrisJobke added this to the Nextcloud 12.0 milestone Mar 26, 2017
@mention-bot
Copy link

@MorrisJobke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @j-ed, @LukasReschke and @icewind1991 to be potential reviewers.

@MorrisJobke MorrisJobke changed the title Downstream 26407 Redis cluster support Mar 26, 2017
@rullzer rullzer requested a review from icewind1991 March 26, 2017 08:02
@MorrisJobke MorrisJobke mentioned this pull request Apr 5, 2017
Closed
@MorrisJobke MorrisJobke added 1. to develop Accepted and waiting to be taken care of and removed 3. to review Waiting for reviews labels Apr 13, 2017
@MorrisJobke MorrisJobke mentioned this pull request Apr 26, 2017
Closed
@MorrisJobke MorrisJobke added 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of labels Apr 26, 2017
rullzer
rullzer approved these changes Apr 26, 2017
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and a quick test run did work. However, I would like to see tests in the not to distant future!

@rullzer rullzer merged commit 752b219 into master Apr 26, 2017
@rullzer rullzer deleted the downstream-26407 branch April 26, 2017 06:27
@MorrisJobke MorrisJobke mentioned this pull request May 2, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@icewind1991 icewind1991 icewind1991 approved these changes

@LukasReschke LukasReschke Awaiting requested review from LukasReschke

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees
No one assigned
Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 12.0
Development

Successfully merging this pull request may close these issues.
6 participants
@MorrisJobke @mention-bot @rullzer @icewind1991 @RobinMcCorkell @butonic