-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dav): add webhook compatibility for calendar object events #51082
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this going to be a public API?
The events are in OCA, not OCP. There are no compatibility or stability guarantees in private app namespaces.
Ah right, I forgot about that. So if webhooks can only listen to events in the public namespace, would adding a new namespace such as EDIT: actually, in the webhook listeners documentation, there are some webhook events that are still in the OCA namespace, so I'm not sure if the workaround is really necessary. |
That is true and worrying to me, but on the other hand not my responsibility. For caldav and carddav I will require a strict separation of private and public API, so we can continue to make easy modifications to internals, and have a solid, stable API for selected classes. So yes, if these events are consumed by other apps, please move them to OCP. Do not extend private types from the public API. Just move them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above. The goal of this PR is to expose a public API, which internal events aren't.
Thanks you for you contribution
aa749d0
to
82477b8
Compare
/backport to stable31 |
@AndyScherzinger are we backporting new APIs for this? |
Signed-off-by: Edward Ly <[email protected]>
82477b8
to
7ee0155
Compare
In this case yes, else the customer needs to wait until v32 enterprise. |
Summary
Adds webhook compatibility to events related to calendar objects (e.g. calendar events) via implementation of
OCP\EventDispatcher\IWebhookCompatibleEvent
.TODO
Checklist