feat(OCM-invites): Implementation of invitation flow for OCM 1.1.0 #51113
+373
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Navid Shokri <[email protected]> Signed-off-by: Micke Nordin <[email protected]> Signed-off-by: Navid Shokri <[email protected]>
nickvergessen
requested changes
Feb 28, 2025
apps/cloud_federation_api/lib/Controller/RequestHandlerController.php
Outdated
Show resolved
Hide resolved
apps/cloud_federation_api/lib/Controller/RequestHandlerController.php
Outdated
Show resolved
Hide resolved
apps/cloud_federation_api/lib/Controller/RequestHandlerController.php
Outdated
Show resolved
Hide resolved
apps/cloud_federation_api/lib/Migration/Version1015Date202502262004.php
Outdated
Show resolved
Hide resolved
apps/cloud_federation_api/lib/Migration/Version1015Date202502262004.php
Outdated
Show resolved
Hide resolved
apps/cloud_federation_api/lib/Migration/Version1015Date202502262004.php
Outdated
Show resolved
Hide resolved
apps/cloud_federation_api/lib/Migration/Version1015Date202502262004.php
Outdated
Show resolved
Hide resolved
apps/cloud_federation_api/lib/Migration/Version1015Date202502262004.php
Outdated
Show resolved
Hide resolved
apps/cloud_federation_api/lib/Migration/Version1015Date202502262004.php
Outdated
Show resolved
Hide resolved
This patchset implements the /invite-accepted endpoint https://cs3org.github.io/OCM-API/docs.html?branch=v1.1.0&repo=OCM-API&user=cs3org#/paths/~1invite-accepted/post Also normalize names of columns, and populate them all Inspo from: - apps/dav/lib/Migration/Version1005Date20180413093149.php - https://saturncloud.io/blog/what-is-the-maximum-length-of-a-url-in-different-browsers/#maximum-url-length-in-different-browsers - https://www.directedignorance.com/blog/maximum-length-of-email-address Signed-off-by: Micke Nordin <[email protected]>
…ler.php Co-authored-by: Joas Schilling <[email protected]> Signed-off-by: Micke Nordin <[email protected]>
…ler.php Co-authored-by: Joas Schilling <[email protected]> Signed-off-by: Micke Nordin <[email protected]>
Signed-off-by: Micke Nordin <[email protected]>
…62004.php Co-authored-by: Joas Schilling <[email protected]> Signed-off-by: Micke Nordin <[email protected]>
…62004.php Co-authored-by: Joas Schilling <[email protected]> Signed-off-by: Micke Nordin <[email protected]>
Empty strings are needed when creating invite. Signed-off-by: Micke Nordin <[email protected]>
The ui part of this, where you can create and delete invites are coming in a companion pr for the contacts app. |
| use OCP\Migration\IOutput; | ||
| use OCP\Migration\SimpleMigrationStep; | ||
|
|
||
| class Version1015Date202502262004 extends SimpleMigrationStep |
There was a problem hiding this comment.
Sorry, missed it before. When adding a migration you have to bump the version in the apps appinfo/info.xml
There was a problem hiding this comment.
I think this is correct now?
|
When working on the front end part, I realized we need an event to react to, so I added that. |
I realize that we need to be able to react to accepted invites elsewhere, e.g. contacts app, so adding invite class and event for that purpose. Co-authored-by: Navid Shokri <[email protected]> Signed-off-by: Micke Nordin <[email protected]> Signed-off-by: Navid Shokri <[email protected]>
This needs to be done for migration to take affect Signed-off-by: Micke Nordin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This patchset implements the /invite-accepted endpoint
https://cs3org.github.io/OCM-API/docs.html?branch=v1.1.0&repo=OCM-API&user=cs3org#/paths/~1invite-accepted/post
A companion PR with UI for creating and otherwise lifecycle manage OCM invites is in the works for the Contacts app, but that work needs this first.