Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use system theme if no ncTheme available #215

Merged

Conversation

grnd-alt
Copy link
Member

resolves: #208

@grnd-alt grnd-alt linked an issue Oct 10, 2024 that may be closed by this pull request
@juliusknorr juliusknorr added the bug Something isn't working label Oct 10, 2024
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works with:

  • system light mode, public share link
  • system dark mode, public share link
  • switching system mode while whiteboard is open
  • Nextcloud mode forced light
  • Nextcloud mode forced dark

@juliusknorr juliusknorr merged commit 7f367e3 into main Oct 10, 2024
26 checks passed
@juliusknorr juliusknorr deleted the fix/208-bug-link-share-does-not-respect-system-dark-mode branch October 10, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] link-share does not respect system dark mode
2 participants