Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CLI fetch inputs #1397

Merged
merged 4 commits into from
Feb 20, 2025
Merged

fix: CLI fetch inputs #1397

merged 4 commits into from
Feb 20, 2025

Conversation

dprats
Copy link
Collaborator

@dprats dprats commented Feb 20, 2025

this PR addresses issue with CLI fetching inputs from orchestrator

Copy link

github-actions bot commented Feb 20, 2025

Visit the preview URL for this PR (updated for commit 9ad9641):

https://nexus-cli--pr1397-dprats-orchestrator-psottojh.web.app

(expires Thu, 27 Feb 2025 19:46:53 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 815ec4c632754f56eccfacfc0919559f5a85a0f1

@monstertrakk
Copy link

Do you debug the CLI before making edits to the code on github?

@dprats
Copy link
Collaborator Author

dprats commented Feb 20, 2025

Do you debug the CLI before making edits to the code on github?

Good question, thank you for asking @monstertrakk. Yes, we test as one would expect (local, across multiple machine/environments). Of course bugs do sneak in...

However, I think the higher level truth is that the bulk of the issues last 48 hours have been with unexpected demand. But team has made significant improvements here through sleepless nights.

I do appreciate the attention on this repo as the open source "face of the network", and unfortunately this client has had to adapt to these. But we do believe they are more stable now.

@ralymov
Copy link

ralymov commented Feb 20, 2025

Even with this commit - it returns either Invalid proof or buffer underflow (and this by the way is taken as successful sending of the proof, which I doubt).

Are you testing on some other orchestrator URL other than beta?
image

@monstertrakk
Copy link

Do you debug the CLI before making edits to the code on github?

Good question, thank you for asking @monstertrakk. Yes, we test as one would expect (local, across multiple machine/environments). Of course bugs do sneak in...

However, I think the higher level truth is that the bulk of the issues last 48 hours have been with unexpected demand. But team has made significant improvements here through sleepless nights.

I do appreciate the attention on this repo as the open source "face of the network", and unfortunately this client has had to adapt to these. But we do believe they are more stable now.

Update the release so everyone can update if your fix really helps. The command “curl https://cli.nexus.xyz/ | sh” does not put your fix into prover.rs

@monstertrakk
Copy link

@dprats
Your fix was manually entered into the .rs files, but that did not work.

root@vmi2408477:~/.nexus/network-api/clients/cli# cargo run --release -- --start --beta
Compiling nexus-network v0.5.3 (/root/.nexus/network-api/clients/cli)
Finished release profile [optimized] target(s) in 2m 40s
Running target/release/nexus-network --start --beta
error: unexpected argument '--start' found

Usage: nexus-network

For more information, try '--help'.

@evaleries
Copy link

@dprats Your fix was manually entered into the .rs files, but that did not work.

root@vmi2408477:~/.nexus/network-api/clients/cli# cargo run --release -- --start --beta Compiling nexus-network v0.5.3 (/root/.nexus/network-api/clients/cli) Finished release profile [optimized] target(s) in 2m 40s Running target/release/nexus-network --start --beta error: unexpected argument '--start' found

Usage: nexus-network

For more information, try '--help'.

the latest command should be cargo run --release -- start --env beta

@monstertrakk
Copy link

@dprats Will the testnet be extended or will it end on schedule? Please check with the CEO!

dprats and others added 2 commits February 20, 2025 11:45
@dprats
Copy link
Collaborator Author

dprats commented Feb 20, 2025

Update the release so everyone can update if your fix really helps. The command “curl https://cli.nexus.xyz/ | sh” does not put your fix into prover.rs

yes that is by design. We were still testing things. once i cut the release, it will be live via curl.

@dprats dprats merged commit 9568a30 into main Feb 20, 2025
3 checks passed
@dprats
Copy link
Collaborator Author

dprats commented Feb 20, 2025

Update: This is now merged and part of a new release

@dprats
Copy link
Collaborator Author

dprats commented Feb 20, 2025

Even with this commit - it returns either Invalid proof or buffer underflow (and this by the way is taken as successful sending of the proof, which I doubt).
good catch. that buffer underflow error is not relevant for the attribution of proofs (users still get credit in orchestrator) so that is just noise we removed for now

@monstertrakk
Copy link

Update: This is now merged and part of a new release

It's work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants