Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix Slider component type definition #2137

Merged
merged 3 commits into from
Jan 30, 2021

Conversation

HellWolf93
Copy link
Collaborator

fix: #2127

Changes proposed in this PR:

@commit-lint
Copy link

commit-lint bot commented Jan 28, 2021

Bug Fixes

  • fix event callback parameter type (5f689ac)
  • update types on input events (4c67269)

Contributors

HellWolf93, TahimiLeonBravo

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@github-actions
Copy link

github-actions bot commented Jan 28, 2021

Visit the preview URL for this PR (updated for commit 070202c):

https://react-rainbow--pr2137-fix-slider-type-defi-s4ho7vkd.web.app

(expires Sat, 06 Feb 2021 05:47:30 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@codeclimate
Copy link

codeclimate bot commented Jan 30, 2021

Code Climate has analyzed commit 070202c and detected 0 issues on this pull request.

View more on Code Climate.

@LeandroTorresSicilia LeandroTorresSicilia merged commit 36e84e6 into master Jan 30, 2021
@LeandroTorresSicilia LeandroTorresSicilia deleted the fix-slider-type-definitions branch January 30, 2021 15:25
jpetaux pushed a commit to jpetaux/react-rainbow that referenced this pull request Jun 27, 2021
* fix: fix event callback parameter type

fix: nexxtway#2127

* fix: update types on input events

Co-authored-by: Tahimi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: Slider onChange function type problem
3 participants