feat: implement ZoomableImage component #2237
Conversation
Features
Bug Fixes
ContributorsHellWolf93, TahimiLeonBravo, LeandroTorresSicilia Commit-Lint commandsYou can trigger Commit-Lint actions by commenting on this PR:
|
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| ); | ||
| }; | ||
|
|
||
| ZoomedImage.propTypes = { |
There was a problem hiding this comment.
Similar blocks of code found in 6 locations. Consider refactoring.
| ); | ||
| }; | ||
|
|
||
| ZoomableImage.propTypes = { |
There was a problem hiding this comment.
Similar blocks of code found in 6 locations. Consider refactoring.
|
Visit the preview URL for this PR (updated for commit 4759903): https://react-rainbow--pr2237-implement-zoomableim-xno7khcn.web.app (expires Sat, 29 May 2021 15:47:10 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
|
@HellWolf93 theme should work here, for example the background should change when change the theme |
| z-index: ${ZINDEX_OVERLAY}; | ||
| `; | ||
|
|
||
| export const StyledBackdrop = attachThemeAttrs(styled.div)` |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| ); | ||
| }; | ||
|
|
||
| ZoomableImage.propTypes = { |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
|
|
||
| return ( | ||
| <> | ||
| <StyledImage |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| /** The intrinsic width of the image in pixels. Must be an integer without a unit. */ | ||
| width: number; | ||
| /** The intrinsic height of the image, in pixels. Must be an integer without a unit. */ | ||
| height: number; |
There was a problem hiding this comment.
let's put optional all props
|
Code Climate has analyzed commit 4759903 and detected 7 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
* feat: implement ZoomableImage component fix: nexxtway#2235 * fix: add padding to zoomed image * fix: use theme background on backdrop * fix: add ZoomableImage assets * fix: add RainbowThemeContainer thumb * fix: add description to props * fix: declare props on index.d.ts * fix: add className and style props * fix: fix stylelint errors * Update RainbowThemeContainer.svg * fix: eslint error * fix: update test to include image padding * Update RainbowThemeContainer.svg Co-authored-by: Tahimi <[email protected]> Co-authored-by: Jose Leandro Torres <[email protected]> Co-authored-by: TahimiLeonBravo <[email protected]>
fix: #2235
Changes proposed in this PR:
Implement ZoomableImage component
Fix typo on z-index constants
I have followed (at least) the PR section of the contributing guide.