Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: onBlur event on Picklist fires on click #2303

Merged
merged 3 commits into from
Oct 24, 2021

Conversation

HellWolf93
Copy link
Collaborator

fix: #2285

Changes proposed in this PR:

@commit-lint
Copy link

commit-lint bot commented Oct 19, 2021

Bug Fixes

  • onBlur event on Picklist fires on click (b0a994c)
  • fire onBlur event on outside click (63eaaf3)

Contributors

HellWolf93, LeandroTorresSicilia

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@github-actions
Copy link

github-actions bot commented Oct 19, 2021

Visit the preview URL for this PR (updated for commit 487e6b6):

https://react-rainbow--pr2303-picklist-onblur-guk5rifk.web.app

(expires Sun, 31 Oct 2021 22:10:50 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@HellWolf93
Copy link
Collaborator Author

The issue also mentions changing the onBlur parameter from value to the synthetic event. I think this is not feasible because it will be a breaking change, but maybe we could add the event as a second parameter

@LeandroTorresSicilia
Copy link
Member

LeandroTorresSicilia commented Oct 24, 2021

@HellWolf93 we should also send the blur event when you open the picklist menu and then click outside, now it is not firing

@codeclimate
Copy link

codeclimate bot commented Oct 24, 2021

Code Climate has analyzed commit 487e6b6 and detected 0 issues on this pull request.

View more on Code Climate.

@LeandroTorresSicilia LeandroTorresSicilia merged commit 4775b22 into master Oct 24, 2021
@LeandroTorresSicilia LeandroTorresSicilia deleted the picklist-onblur branch October 24, 2021 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: Picklist onBlur fires on click
2 participants