fix: update CounterInput buttons behavior #2307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug Fixes
ContributorsCommit-Lint commandsYou can trigger Commit-Lint actions by commenting on this PR:
|
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| @@ -28,6 +28,24 @@ describe('<CounterInput />', () => { | |||
| expect(onChangeMockFn).toHaveBeenCalledWith(1); | |||
| }); | |||
|
|
|||
| it('should fire onChange `min` as argument when click in plusButton', () => { | |||
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| expect(onChangeMockFn).toHaveBeenCalledWith(10); | ||
| }); | ||
|
|
||
| it('should fire onChange `max` as argument when click in minusButton', () => { |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
|
Code Climate has analyzed commit b2be2c0 and detected 5 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
|
Visit the preview URL for this PR (updated for commit b2be2c0): https://react-rainbow--pr2307-fix-counterinput-ran-w2p526ne.web.app (expires Wed, 27 Oct 2021 19:27:27 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
TahimiLeonBravo
approved these changes
Oct 20, 2021
LeandroTorresSicilia
approved these changes
Oct 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #2302
Changes proposed in this PR:
Updated CounterInput
+and-to math native input behaviourI have followed (at least) the PR section of the contributing guide.