Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add headerAlignment prop to the Column component #2339

Merged
merged 6 commits into from
Dec 18, 2021

Conversation

HellWolf93
Copy link
Collaborator

fix: #2337

Changes proposed in this PR:

@commit-lint
Copy link

commit-lint bot commented Dec 16, 2021

Features

  • add headerAlignment prop to Column component (03a041b)

Tests

  • fix Table tests for headerAlignment (34052aa)

Bug Fixes

  • fix failing test case on getColumns (d280f41)
  • change sort icon position when header alignment right (ceb40d2)

Documentation

Contributors

HellWolf93, TahimiLeonBravo, LeandroTorresSicilia

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@github-actions
Copy link

github-actions bot commented Dec 16, 2021

Visit the preview URL for this PR (updated for commit 4130a40):

https://react-rainbow--pr2339-add-header-alignment-tri9u24w.web.app

(expires Sat, 25 Dec 2021 03:00:04 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@TahimiLeonBravo
Copy link
Collaborator

@HellWolf93 when the alignment is "right" I think that the sort arrow should be on the left of the content
Screen Shot 2021-12-17 at 10 24 01 AM

@codeclimate
Copy link

codeclimate bot commented Dec 18, 2021

Code Climate has analyzed commit 4130a40 and detected 10 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 10

View more on Code Climate.

@LeandroTorresSicilia LeandroTorresSicilia merged commit 9ddc826 into master Dec 18, 2021
@LeandroTorresSicilia LeandroTorresSicilia deleted the add-header-alignment branch December 18, 2021 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add headerAlignment prop to the ColumnComponent component
3 participants