Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messing around with .travis.yml #1

Merged
merged 6 commits into from
Apr 6, 2018
Merged

Messing around with .travis.yml #1

merged 6 commits into from
Apr 6, 2018

Conversation

ewels
Copy link
Member

@ewels ewels commented Mar 29, 2018

I think that the builds are still timing out for some reason.

Also want to check that nf-core doesn't run with --release as this PR goes to the dev branch.

@ewels
Copy link
Member Author

ewels commented Mar 29, 2018

Dockerhub is making me sad 😞

@ewels ewels requested a review from a team April 4, 2018 13:28
@ewels
Copy link
Member Author

ewels commented Apr 4, 2018

Oops, accidentally opened a duplicate PR #2


Tests failing as I can't create the repository on dockerhub currently.

  • Remove groovy syntax strings
  • Playing with tidier installation script and travis config
  • Minor pipeline name tweaks

Now the tests are failing because the new nfcore/base image isn't ready. Hopefully it will be soon and the tests can be rerun.

@ewels ewels mentioned this pull request Apr 4, 2018
@@ -6,6 +6,8 @@
# s = singularity
# t = nf-core/tools

SGT_VER=2.4.5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see that you simplified the actual Travis tests, but that way, you'll have to specify the Singularity version here, and not in the tests.
Wouldn't that be more complicated in the end?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I figured that it's pretty rare to need to update the singularity version.. How often does that change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(in contrast to the Nextflow version, which changes a lot)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, yeah ok - fairly often I guess... http://singularity.lbl.gov/all-releases

So in this case should we also have a "minimum singularity version" then?

@ewels
Copy link
Member Author

ewels commented Apr 4, 2018

HiSAT2 tests now passing 🎉

STAR tests still timing out as they always have. Previously we just didn't run these tests, but that feels kind of unsatisfactory.

@maxulysse
Copy link
Member

Have you tried with travis_wait 50 or something like that?
cf SciLifeLab/Sarek@bc408e0

@ewels
Copy link
Member Author

ewels commented Apr 5, 2018

I tried travis_wait 30 and it failed, but I think that may have been for a different reason. Maybe I'll try again..

@maxulysse
Copy link
Member

I noticed that afterwards...
I never managed to make the travis_retry work, but the travis_wait was working well until I managed to simplify our tests.

@ewels
Copy link
Member Author

ewels commented Apr 6, 2018

I'm going to force a merge here - the code is fine, it's just the travis tests which are being stupid and they can be fixed in a future commit.

@ewels ewels merged commit a426a34 into nf-core:dev Apr 6, 2018
apeltzer pushed a commit that referenced this pull request Feb 11, 2020
enhance file name parsing for STAR/HISAT2
pranathivemuri added a commit that referenced this pull request Jun 8, 2020
Output concatenated genome fasta to RSEM reference
drpatelh pushed a commit that referenced this pull request Oct 29, 2021
@Raysun61 Raysun61 mentioned this pull request Mar 7, 2022
pinin4fjords pushed a commit to pinin4fjords/rnaseq that referenced this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants