-
Notifications
You must be signed in to change notification settings - Fork 722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Messing around with .travis.yml #1
Conversation
Dockerhub is making me sad 😞 |
Oops, accidentally opened a duplicate PR #2 Tests failing as I can't create the repository on dockerhub currently.
Now the tests are failing because the new |
@@ -6,6 +6,8 @@ | |||
# s = singularity | |||
# t = nf-core/tools | |||
|
|||
SGT_VER=2.4.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see that you simplified the actual Travis tests, but that way, you'll have to specify the Singularity version here, and not in the tests.
Wouldn't that be more complicated in the end?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I figured that it's pretty rare to need to update the singularity version.. How often does that change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(in contrast to the Nextflow version, which changes a lot)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, yeah ok - fairly often I guess... http://singularity.lbl.gov/all-releases
So in this case should we also have a "minimum singularity version" then?
HiSAT2 tests now passing 🎉 STAR tests still timing out as they always have. Previously we just didn't run these tests, but that feels kind of unsatisfactory. |
Have you tried with |
I tried |
I noticed that afterwards... |
I'm going to force a merge here - the code is fine, it's just the travis tests which are being stupid and they can be fixed in a future commit. |
enhance file name parsing for STAR/HISAT2
Output concatenated genome fasta to RSEM reference
Use publish dir but with no functions.nf
I think that the builds are still timing out for some reason.
Also want to check that
nf-core
doesn't run with--release
as this PR goes to thedev
branch.