-
Notifications
You must be signed in to change notification settings - Fork 722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RSEQC3.0 Support #151
RSEQC3.0 Support #151
Conversation
Seams updating to the 3.0.0 recipe doesn't break anything locally, which is a good start 👍 I'll make the changes to utilize the former way of doing things without the bigWig later. |
MultiQC Report looks sane to me as well: |
Looks ok to me @ewels what do you think? This is on RSEQC3.0, with subsampling again without actually creating bigWig files anymore. Runtime was
|
Looks great! To be honest, I can't remember which rseqc outputs generated MultiQC sections before. But good that gene body coverage is still there 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Couple of minor suggestions.
Separate note: it would be good to cut the .sorted.markDups
off the sample names for MultiQC. Needs a minor addition to multiqc_config.yml
:
extra_fn_clean_exts:
- '.sorted.markDups'
(also, it's confusing as hell that the test input files have _subsamp.fastq.gz
filenames 😆 - maybe we should rename them for clarity?)
I think this is fine to go ...? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nearly! Couple of minor docs suggestions. I was also looking for it to be added to nextflow.config
but now I realise what you mean - that it's already there from a previous iteration. Looking good! 👍
Co-Authored-By: apeltzer <[email protected]>
Co-Authored-By: apeltzer <[email protected]>
Co-Authored-By: apeltzer <[email protected]>
Brilliant stuff - thanks! |
No description provided.