Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSEQC3.0 Support #151

Merged
merged 7 commits into from
Feb 5, 2019
Merged

RSEQC3.0 Support #151

merged 7 commits into from
Feb 5, 2019

Conversation

apeltzer
Copy link
Member

No description provided.

@apeltzer apeltzer added the WIP Work in progress label Jan 31, 2019
@apeltzer
Copy link
Member Author

Seams updating to the 3.0.0 recipe doesn't break anything locally, which is a good start 👍

#148

I'll make the changes to utilize the former way of doing things without the bigWig later.

@apeltzer
Copy link
Member Author

MultiQC Report looks sane to me as well:

multiqc_report.html.zip

@apeltzer apeltzer requested a review from ewels January 31, 2019 15:26
@apeltzer
Copy link
Member Author

Looks ok to me @ewels what do you think?

multiqc_report.html.zip

This is on RSEQC3.0, with subsampling again without actually creating bigWig files anymore. Runtime was

The workflow was completed at Thu Jan 31 16:39:35 CET 2019 (duration: 3m 46s)

The command used to launch the workflow was as follows:

@apeltzer apeltzer removed the WIP Work in progress label Jan 31, 2019
@ewels
Copy link
Member

ewels commented Feb 1, 2019

Looks great! To be honest, I can't remember which rseqc outputs generated MultiQC sections before. But good that gene body coverage is still there 👍

Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Couple of minor suggestions.

Separate note: it would be good to cut the .sorted.markDups off the sample names for MultiQC. Needs a minor addition to multiqc_config.yml:

extra_fn_clean_exts:
    - '.sorted.markDups'

(also, it's confusing as hell that the test input files have _subsamp.fastq.gz filenames 😆 - maybe we should rename them for clarity?)

@apeltzer
Copy link
Member Author

apeltzer commented Feb 4, 2019

I think this is fine to go ...?

Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nearly! Couple of minor docs suggestions. I was also looking for it to be added to nextflow.config but now I realise what you mean - that it's already there from a previous iteration. Looking good! 👍

ewels and others added 3 commits February 5, 2019 10:21
Co-Authored-By: apeltzer <[email protected]>
Co-Authored-By: apeltzer <[email protected]>
Co-Authored-By: apeltzer <[email protected]>
@ewels ewels merged commit 99a6b7d into nf-core:dev Feb 5, 2019
@ewels
Copy link
Member

ewels commented Feb 5, 2019

Brilliant stuff - thanks!

@apeltzer apeltzer deleted the rseqc3.0 branch June 8, 2019 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants