Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ascat computes all possible N-T combinations #136

Closed
ggabernet opened this issue Mar 3, 2020 · 1 comment
Closed

Ascat computes all possible N-T combinations #136

ggabernet opened this issue Mar 3, 2020 · 1 comment
Assignees

Comments

@ggabernet
Copy link
Member

Hi, I was wondering why 25 ascat processes were started when I had just 5 Tumor-Normal pairs, and it turns out that ascat computes all possible N-T combinations. Eg:

Ascat_CHC2113T_vs_CHC2113N
Ascat_CHC2113T_vs_CHC2115N
Ascat_CHC2113T_vs_CHC912N

I can also help with fixing that, just wanted to document it in an issue :)

@lconde-ucl
Copy link
Member

lconde-ucl commented Mar 4, 2020

We fixed it in our local copy of sarek by adding by: 0 in alleleCountNormal.combine. Please note that alleleCountOutput.map needs to be modified accordingly too:

alleleCountOutput
  .choice(alleleCountTumor, alleleCountNormal) {it[1] == 0 ? 1 : 0}

alleleCountOutput = alleleCountNormal.combine(alleleCountTumor, by: 0)

alleleCountOutput = alleleCountOutput.map {
  idPatientNormal, statusNormal, idSampleNormal, alleleCountNormal,
  statusTumor,  idSampleTumor,  alleleCountTumor ->
  [idPatientNormal, idSampleNormal, idSampleTumor, alleleCountNormal, alleleCountTumor]
}

Hope this helps
Lucia

PS: I should have specified that the above changes fixed this issue in the "SciLifeLab/Sarek" pipeline, which is the pipeline we were using, but the same changes should fix it in "nf-core/sarek" as well

maxulysse added a commit that referenced this issue Mar 5, 2020
Fix issue #136: Ascat computes all possible N-T combinations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants