Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ascat Rscript calling #133

Merged
merged 3 commits into from
Mar 1, 2020
Merged

fix ascat Rscript calling #133

merged 3 commits into from
Mar 1, 2020

Conversation

ggabernet
Copy link
Member

Somehow this was not properly fixed, it threw me an error again when running on AWS

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: CONTRIBUTING.md

@ggabernet ggabernet requested a review from maxulysse as a code owner March 1, 2020 10:58
@maxulysse
Copy link
Member

I have a feeling, I've seen this PR before.
Looks strangely a lot like #127
Before looking more into this one, are you sure your dev branch is sync to the nf-core dev branch?

@maxulysse
Copy link
Member

It seems I got some old code when I merge some #131
Sorry about that

@maxulysse maxulysse merged commit e0f7305 into nf-core:dev Mar 1, 2020
@ggabernet
Copy link
Member Author

sure, thanks! I also didn't see it on the last review...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants