-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make ControlFREEC work for WES and WGS data in both paired and tumor-only modes #302
Changes from all commits
3909d8f
90a9587
d838905
864c7e8
6911bf3
04fb29a
bc17ae9
5091752
22b18c7
fcaca32
31aaefe
62fd810
c1eef46
47de309
b0a0c76
dd2d403
9d01fd3
acd0ea5
c8ae43d
4fac08c
dbd8537
45f3502
687caa9
0774484
fdca828
0cc2d82
4e3202a
ce5cc36
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -49,9 +49,9 @@ params { | |
// Variant Calling | ||
ascat_ploidy = null // Use default value | ||
ascat_purity = null // Use default value | ||
cf_coeff = "0.015" // default value for Control-FREEC | ||
cf_coeff = "0.05" // default value for Control-FREEC | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Dunno, what is the default value, and why exactly are we changing it? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We are changing it to the default value as recommend in their manual (http://boevalab.inf.ethz.ch/FREEC/tutorial.html). Was there any specific reason to use a value different than the default one? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Well, our colleagues played with that, and were happier with 0.05. Will ask why. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I see :) I personally believe that is nice to have as default the same as in Control-FREEC specially given that this parameter can be changed by the user. The optimal value is probably different for every case but of course I may be wrong here. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As I check the Control-FREEC source, this value is used only at one place: https://github.com/BoevaLab/FREEC/blob/master/src/GenomeCopyNumber.cpp#L60 and the sole purpose is to calculate the windowSize, if it is not provided in the config. For the clarity, it is actually There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Interesting, the recommended setting for WES is to use cv_window = 0. I added an entry about that in the docs. It may be a good idea to mention this for the cv_coef parameter. |
||
cf_ploidy = "2" // you can use 2,3,4 | ||
cf_window = "" // by default we are not using this in Control-FREEC | ||
cf_window = null // by default we are not using this in Control-FREEC | ||
no_gvcf = null // g.vcf are produced by HaplotypeCaller | ||
no_strelka_bp = null // Strelka will use Manta candidateSmallIndels if available | ||
pon = false // No default PON (Panel of Normals) file for GATK Mutect2 / Sentieon TNscope | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually as for tools, the string is stripped out of
_
and-
and lowercased, soControl-FREEC
should actually work.I would prefer that spelling as it's the one from the tool itself
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed!