Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #850

Closed
wants to merge 128 commits into from
Closed

Update README.md #850

wants to merge 128 commits into from

Conversation

maxulysse
Copy link
Member

Replacing Docker by BioContainers.
That way we cover both Docker and Singularity

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

KevinMenden and others added 30 commits January 5, 2021 09:41
indicates the necessity to add all required software to the path. This is important for pipelines with multiple environments.
* Use ansi colours for the default values and filled values in the group select view of params (#816)
* Add to group select prompt a warning that a value is required, if not yet filled and no default
Closes #299

Also bumped minimum Rich version as latest release is a bug hotfix.
ewels and others added 24 commits February 8, 2021 23:47
Also move the AWS workflow env vars to the top level so that they work for any additional job steps added by developers.
Also a minor bugfix for fixing files with changes - use shutil.copy() instead of doing it manually
Need 2 spaces to indent, not 1
Update PULL_REQUEST_TEMPLATE.md
This config has been moved to nf-core/configs and is no longer referenced in nextflow.config, but the template sync doesn't seem to pick up that the config file should be deleted.
Linting: Check that aws.config is deleted
…n 3.6

Automated tests are amazing.. Would never have found this otherwise!
Lint: new files_unchanged test to check that files are not modified from the template
Replacing Docker by BioContainers.
That way we cover both Docker and Singularity
@maxulysse maxulysse mentioned this pull request Feb 12, 2021
11 tasks
@maxulysse maxulysse changed the base branch from dev to dsl2_template February 12, 2021 10:02
@maxulysse maxulysse closed this Feb 12, 2021
@maxulysse maxulysse deleted the MaxUlysse-patch-1 branch February 12, 2021 10:02
maxulysse added a commit that referenced this pull request Feb 12, 2021
Replace Docker by BioContainers, that should cover both Docker and Singularity.
repalce previous PR #850 that was made to `dev`
@maxulysse maxulysse mentioned this pull request Feb 12, 2021
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants