Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New versions of templates (almost) finished #14

Merged
merged 20 commits into from
Dec 13, 2021
Merged

Conversation

omaus
Copy link
Collaborator

@omaus omaus commented Dec 13, 2021

  • new template versions now have the content examples from their deprecated versions
  • new template versions now have checklists with the same data like before (except for 3ASY01_RNAseq & 3ASY04_Genomics due to [BUG] Adding a new Building Block to an existing Swate table returns error Swate#180 )
  • new template versions now have ER sheets, filled and formatted ✨
  • deprecated templates are gone now (still accessible via commit history)
  • there's a lot of F# scripts which can be ignored by non-developers, they are WIP 🚧

@omaus omaus self-assigned this Dec 13, 2021
@omaus omaus merged commit 0eafb51 into nfdi4plants:main Dec 13, 2021
@Brilator
Copy link
Member

Cool. This is a bit cleaner and more straight-forward. Only downside is, that you don't see dependencies across ERs anymore in one sheet. But that should be fine.

  • I guess one of the F# scripts will allow to easily edit / convert the ER sheets upon adding building blocks in the original template?

  • Now that we've cut it down to one workbook only (no additional json), I would suggest to move the template workbooks out of their folders. But this probably needs to be adapted in swobup first? @Zerskk

  • And just a reminder to us, we still require the "mapping notes" in the SWATE_templates_WD to capture (a) terms that are not mapped at all, (b) terms that are not mapped by a template (e.g. come from a different ARC source). So we need work on the redundancy between the ER sheets in the template workbooks and the "mapping notes" there (depending on instructions for what info the converter needs).

  • And probably most importantly, we need to adapt the documentation for (a) how to build a template from scratch and (b) how to reuse and adapt an existing template for a new ER or data type (both with / without F# scripts?).

@Zerskk
Copy link
Member

Zerskk commented Dec 14, 2021

Workbooks outside folders are already supported by Swobup.

@omaus
Copy link
Collaborator Author

omaus commented Dec 14, 2021

I guess one of the F# scripts will allow to easily edit / convert the ER sheets upon adding building blocks in the original template?

That's in the working. Atm. the scripts mainly work for the old deprecated versions. I'm thinking about developing an executable file or sth. alike which aims for automation.

So we need work on the redundancy between the ER sheets in the template workbooks and the "mapping notes" there (depending on instructions for what info the converter needs).

Yes. I'm also thinking about how we can address this in a nice way.

And probably most importantly, we need to adapt the documentation for (a) how to build a template from scratch and (b) how to reuse and adapt an existing template for a new ER or data type (both with / without F# scripts?).

Exactly. As soon as the algorithm for the new template versions is finished, we should tackle that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants