Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add notifier for Azure service bus #302

Merged
merged 4 commits into from
Apr 24, 2024
Merged

add notifier for Azure service bus #302

merged 4 commits into from
Apr 24, 2024

Conversation

ktong
Copy link
Collaborator

@ktong ktong commented Apr 24, 2024

part of #266

Copy link

codecov bot commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 11.76471% with 120 lines in your changes are missing coverage. Please review.

Project coverage is 82.7%. Comparing base (f81be18) to head (e244c39).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #302     +/-   ##
=======================================
- Coverage   86.5%   82.7%   -3.9%     
=======================================
  Files         58      61      +3     
  Lines       2506    2636    +130     
=======================================
+ Hits        2170    2182     +12     
- Misses       254     371    +117     
- Partials      82      83      +1     
Files Coverage Δ
notifier/azservicebus/internal/assert/assert.go 42.8% <42.8%> (ø)
provider/azblob/blob.go 86.2% <63.6%> (-1.3%) ⬇️
notifier/azservicebus/option.go 0.0% <0.0%> (ø)
notifier/azservicebus/notifier.go 5.4% <5.4%> (ø)

@ktong ktong merged commit 7330da5 into main Apr 24, 2024
65 of 67 checks passed
@ktong ktong deleted the kt_sb branch April 24, 2024 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant