Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove use of meta = with lib; #292

Merged
merged 1 commit into from
Aug 14, 2024
Merged

remove use of meta = with lib; #292

merged 1 commit into from
Aug 14, 2024

Conversation

eclairevoyant
Copy link
Contributor

@eclairevoyant eclairevoyant commented Oct 1, 2023 •
edited
Loading

Motivating discussion: NixOS/nixpkgs#208242

Additional context: NixOS/nixpkgs#292468, NixOS/nixpkgs#293767

Fixes #414.

Gerg-L
Gerg-L approved these changes Oct 11, 2023
View reviewed changes
Copy link

@Gerg-L Gerg-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eclairevoyant
Copy link
Contributor Author

@figsoda any feedback on this?

@eclairevoyant eclairevoyant mentioned this pull request Feb 28, 2024
Closed
@figsoda
Copy link
Member

figsoda commented Mar 5, 2024 •
edited
Loading

Sorry that I forgot about this for so long. Is there a consensus on this? If not maybe I can create a poll or something like that

@Gerg-L
Copy link

Gerg-L commented Mar 5, 2024

In my experience it gets constantly nitpicked in nixpkgs,
and the main argument for it is the removal of boilerplate which is irrelevant with an automatic tool

@mweinelt
Copy link
Member

mweinelt commented Mar 11, 2024 •
edited
Loading

No, there is no consensus on removing it from meta. The same people are constantly pushing for it and steamrolling maintainers, and in the latest case my review concerns were heard, but ultimately ignored.

@eclairevoyant eclairevoyant changed the title remove uses of with lib; (see NixOS/nixpkgs#208242) remove uses of with lib; Mar 11, 2024
@eclairevoyant

This comment was marked as outdated.

Sign in to view
@eclairevoyant eclairevoyant changed the title remove uses of with lib; remove use of meta = with lib; Mar 11, 2024
@eclairevoyant
Copy link
Contributor Author

eclairevoyant commented Mar 27, 2024 •
edited
Loading

NB as mentioned in NixOS/nixpkgs#292468 (comment), meta = with lib; has shown itself to be a footgun as well.

(TLDR version is available from both lib and the derivation.)

@eclairevoyant
Copy link
Contributor Author

@figsoda as mentioned 4 months ago, this is no longer a nit and is actually an issue; any chance to look at this again?

@doronbehar doronbehar mentioned this pull request Aug 5, 2024
Closed
13 tasks
@AndersonTorres AndersonTorres mentioned this pull request Aug 13, 2024
Open
@Mic92
Copy link
Member

Mic92 commented Aug 14, 2024

@mergify queue

@mergify Mergify
Copy link

mergify bot commented Aug 14, 2024 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at b5a81ec

mergify bot added a commit that referenced this pull request Aug 14, 2024
@mergify
Merge of #292
b5ae1d0
@mergify mergify bot merged commit b5a81ec into nix-community:main Aug 14, 2024
2 checks passed
@eclairevoyant eclairevoyant deleted the remove-with-lib branch August 16, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gerg-L Gerg-L Gerg-L approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nixpkgs style
5 participants
@eclairevoyant @figsoda @Gerg-L @mweinelt @Mic92