Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restore missing CSS for HTML components #2726

Merged
merged 1 commit into from
Feb 15, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 41 additions & 0 deletions .changeset/missing-in-action.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
---
"@utrecht/article-css": minor
"@utrecht/blockquote-css": minor
"@utrecht/button-css": minor
"@utrecht/checkbox-css": minor
"@utrecht/code-block-css": minor
"@utrecht/code-css": minor
"@utrecht/document-css": minor
"@utrecht/emphasis-css": minor
"@utrecht/figure-css": minor
"@utrecht/form-fieldset-css": minor
"@utrecht/form-label-css": minor
"@utrecht/form-css": minor
"@utrecht/heading-1-css": minor
"@utrecht/heading-2-css": minor
"@utrecht/heading-3-css": minor
"@utrecht/heading-4-css": minor
"@utrecht/heading-5-css": minor
"@utrecht/heading-6-css": minor
"@utrecht/heading-group-css": minor
"@utrecht/html-content-css": minor
"@utrecht/link-css": minor
"@utrecht/mark-css": minor
"@utrecht/ordered-list-css": minor
"@utrecht/paragraph-css": minor
"@utrecht/radio-button-css": minor
"@utrecht/select-css": minor
"@utrecht/separator-css": minor
"@utrecht/subscript-css": minor
"@utrecht/superscript-css": minor
"@utrecht/table-css": minor
"@utrecht/textarea-css": minor
"@utrecht/textbox-css": minor
"@utrecht/unordered-list-css": minor
---

Restore vanilla HTML implementations to the npm packages of CSS components, with the following files:

- `dist/html/index.css`
- `dist/html/index.min.css`
- `dist/html/index.mjs`
33 changes: 33 additions & 0 deletions packages/build-utils-css/src/index.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import * as sass from 'sass';
import { mergeLicenseComments } from './remove-duplicate-license.mjs';
import { removeComments } from './remove-comments.mjs';
import cssnano from 'cssnano';
import { existsSync } from 'node:fs';

const webpackStyleImporter = {
findFileUrl(url) {
Expand All @@ -26,6 +27,12 @@ const webpackStyleImporter = {
};

const buildStyles = async (config) => {
// Optional files exist only in some packages.
// Continue without action when the input file does not exist.
if (config.optional && !existsSync(config.inputFile)) {
return;
}

try {
// Ensure output directory exists
const outputDir = path.dirname(config.outputFile);
Expand Down Expand Up @@ -131,6 +138,32 @@ buildStyles({
dts: 'dist/index.mjs.d.ts',
});

buildStyles({
inputFile: 'src/html/index.scss',
outputFile: 'dist/html/index.css',
sourceMap: process.env.NODE_ENV === 'development',
minify: false,
optional: true,
});

buildStyles({
inputFile: 'src/html/index.scss',
outputFile: 'dist/html/index.min.css',
sourceMap: process.env.NODE_ENV === 'development',
minify: true,
optional: true,
});

buildStyles({
inputFile: 'src/html/index.scss',
outputFile: 'dist/html/index.mjs',
sourceMap: false,
minify: true,
esm: true,
dts: 'dist/html/index.mjs.d.ts',
optional: true,
});

buildTokens({
inputFile: 'src/tokens.json',
outputFile: 'dist/tokens.mjs',
Expand Down