kernel_patch_verify: allow kmake to do word splitting

More issues with quoting variables that are meant to be split up on usage. KP_PARAMS takes multiple parameters, but gets quoted out.. and similar issues with other variables. Add Documentation around the same not to allow the next person to come and quote things up. Fixes: eeac60b kernel_patch_verify: quote damn near everything Reported-by: Michael Nemanov <[email protected]> Signed-off-by: Nishanth Menon <[email protected]>
nmenon · May 17, 2024 · 3e8da66 · 3e8da66
1 parent ee68e47
commit 3e8da66
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/kernel_patch_verify b/kernel_patch_verify
@@ -71,11 +71,13 @@ if [ -z "$KP_TARGETS" ]; then
 fi
 
 kmake_single() {
-	make "$KM_A" "$KP_PARAMS" "$KM_C" "$KM_L" -j1 $@
+	# XXX: kmake operations depend on variable expansion- do not quote variables here.
+	make $KM_A $KP_PARAMS $KM_C $KM_L -j1 $@
 }
 
 kmake() {
-	make "$KM_A" "$KP_PARAMS" "$KM_C" "$KM_L" -j"$KM_CPUS" $@
+	# XXX: kmake operations depend on variable expansion- do not quote variables here.
+	make $KM_A $KP_PARAMS $KM_C $KM_L -j"$KM_CPUS" $@
 }
 
 ###################