Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support promql field in GCM terraform [PC-14302] #371

Merged
merged 5 commits into from
Jan 24, 2025
Merged

feat: Support promql field in GCM terraform [PC-14302] #371

merged 5 commits into from
Jan 24, 2025

Conversation

dawidwisn
Copy link
Contributor

@dawidwisn dawidwisn commented Dec 19, 2024 •
edited
Loading

Motivation

Support promql field in GCM terraform.

Summary

Example:

  objective {
    display_name = "obj1"
    name         = "tf-objective-1"
    target       = 0.7
    value        = 1
    op           = "lt"
    raw_metric {
      query {
        gcm {
          project_id = "project1"
		  promql = "sum(rate(http_requests_total{job=\"api-server\"}[5m]))"
		}
      }
    }
  }

Related Changes

nobl9/nobl9-go#564

Release Notes

Support promql field in GCM terraform

@n9-machine-user n9-machine-user added the go Pull requests that update Go code label Dec 19, 2024
@dawidwisn dawidwisn changed the title PC-14302 Support promql field in GCM terraform feat: Support promql field in GCM terraform [PC-14302] Dec 19, 2024
@n9-machine-user n9-machine-user added enhancement New feature or request minor New functionality with at most minor breaking changes labels Dec 19, 2024
@dawidwisn dawidwisn marked this pull request as ready for review December 19, 2024 14:48
marcinlawnik
marcinlawnik previously approved these changes Jan 21, 2025
View reviewed changes
@paulina-n9
Copy link
Contributor

lgtm 👌

@paulina-n9 paulina-n9 added the passed-testing Added by QA when tests have passed label Jan 24, 2025
@dawidwisn dawidwisn enabled auto-merge (squash) January 24, 2025 11:04
@dawidwisn dawidwisn merged commit eed1aba into main Jan 24, 2025
5 checks passed
@dawidwisn dawidwisn deleted the PC-14302-support-promql-in-GCM branch January 24, 2025 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdw-nobl9 bdw-nobl9 bdw-nobl9 approved these changes

@marcinlawnik marcinlawnik marcinlawnik left review comments

@skrolikiewicz skrolikiewicz Awaiting requested review from skrolikiewicz skrolikiewicz is a code owner

@nieomylnieja nieomylnieja Awaiting requested review from nieomylnieja nieomylnieja is a code owner

@daniel-zelazny daniel-zelazny Awaiting requested review from daniel-zelazny daniel-zelazny is a code owner

@BSski BSski Awaiting requested review from BSski

Assignees
No one assigned
Labels
enhancement New feature or request go Pull requests that update Go code minor New functionality with at most minor breaking changes passed-testing Added by QA when tests have passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dawidwisn @paulina-n9 @marcinlawnik @bdw-nobl9 @n9-machine-user