-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: update the moderation policy #102
Conversation
Fill in some ambiguous gaps in the moderation policy
88e9b6e
to
6344e41
Compare
@@ -31,10 +31,11 @@ Any alternative Moderation Policy used for a given repository must be included i | |||
|
|||
### Terms | |||
|
|||
* *Collaborator* refers to any individual with configured access permissions to any Node.js GitHub organization repository. See [GitHub's access permissions documentation](https://help.github.com/articles/what-are-the-different-access-permissions/) for more information. | |||
* *Collaborator* refers to any individual with configured write (commit) permissions to any Node.js GitHub organization repository *other than the Moderation Repository*. See [GitHub's access permissions documentation](https://help.github.com/articles/what-are-the-different-access-permissions/) for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does everyone in node/membership have write access specifically to the moderation repo? I could be wrong, but I thought I remembered that only a subset of people have write access.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Every Collaborator should have at least access to view the Moderation Repository and to participate in discussions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could be wrong, but I thought that being a member of the org gave read access, but not write.
On further reflection though, if this is the case, it doesn't make the wording here wrong. Absolute worst case it's a bit superfluous, and best case it makes an important distinction, so there's no downside. I'm ok with this.
This certainly clarifies a few things for me. Thanks jasnell. I particularly like the |
LGTM |
2 similar comments
LGTM |
LGTM |
@jasnell can this land? |
Yep |
Lotsa LGTMs here. Merging. |
Fill in some ambiguous gaps in the moderation policy
/cc @nodejs/tsc