Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update the moderation policy #102

Merged
merged 1 commit into from
Jun 16, 2016

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented May 18, 2016

Fill in some ambiguous gaps in the moderation policy

/cc @nodejs/tsc

Fill in some ambiguous gaps in the moderation policy
@jasnell jasnell force-pushed the update-mod-policy branch from 88e9b6e to 6344e41 Compare May 18, 2016 03:40
@jasnell jasnell mentioned this pull request May 18, 2016
@@ -31,10 +31,11 @@ Any alternative Moderation Policy used for a given repository must be included i

### Terms

* *Collaborator* refers to any individual with configured access permissions to any Node.js GitHub organization repository. See [GitHub's access permissions documentation](https://help.github.com/articles/what-are-the-different-access-permissions/) for more information.
* *Collaborator* refers to any individual with configured write (commit) permissions to any Node.js GitHub organization repository *other than the Moderation Repository*. See [GitHub's access permissions documentation](https://help.github.com/articles/what-are-the-different-access-permissions/) for more information.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does everyone in node/membership have write access specifically to the moderation repo? I could be wrong, but I thought I remembered that only a subset of people have write access.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every Collaborator should have at least access to view the Moderation Repository and to participate in discussions.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could be wrong, but I thought that being a member of the org gave read access, but not write.

On further reflection though, if this is the case, it doesn't make the wording here wrong. Absolute worst case it's a bit superfluous, and best case it makes an important distinction, so there's no downside. I'm ok with this.

@varjmes
Copy link

varjmes commented May 18, 2016

This certainly clarifies a few things for me. Thanks jasnell. I particularly like the write (commit) addition to the Collaborator definition as this is a really good way to describe it.

@bnoordhuis
Copy link
Member

LGTM

2 similar comments
@nebrius
Copy link
Contributor

nebrius commented May 18, 2016

LGTM

@mhdawson
Copy link
Member

LGTM

@MylesBorins
Copy link
Contributor

@jasnell can this land?

@jasnell
Copy link
Member Author

jasnell commented Jun 1, 2016

Yep

@williamkapke
Copy link
Contributor

Lotsa LGTMs here. Merging.

@williamkapke williamkapke merged commit ed4002f into nodejs:master Jun 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants