Add Contribution Guidelines #232
Conversation
Added contribution guidelines: Code, PRs, and Off-Topic.
|
Since most of our PRs here deal with content and internationalization efforts it might be good to build that in here as well. We have a "code" section, which is good (some code is in this repo), but we should probably outline some content suggestions for idealized PRs. |
|
@snostorm Do you have any main points you'd like to be added to the content and internationalization section? |
|
Putting this on the WG Agenda, we'll either merge as-is (or discuss what to add) Monday. |
|
@snostorm Sounds good. I'll be happy to make any changes that are decided on, if you guys want me to. |
|
On the agenda for Mar 2nd Website WG meeting #240 |
|
Content issues somewhat covered by https://github.com/iojs/evangelism/blob/master/socialMedia.styleGuide.md so maybe we can merge with some notes about that |
|
So, in the meeting we decided that although we want to add to this, we'll just merge as-is and hope not to forget to add more. Can we get some WG +1's still on here to make it more official since this is a |
|
+1 |
| * __Two contributor votes for merge:__ Two WG members of Contributor status will need to approve, or +1, your contribution in order for it to be accepted and merged into the main repo. | ||
|
|
||
| #### Off-topic | ||
| * __Off topic PRs:__ Please, avoid posting off-topic issues and PRs. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
There still are some things that need to be worked out in this PR (specifically referring to any/all of the diff comments), adding the do not merge label until they are resolved (or at least discussed a bit more). |
|
@bnb Can you please look into the comments, this PR has been around for so long, it would be great if we finally could get it merged. |
|
Sorry for forgetting about this - I try to be good about issues I create, but i didn't follow through with this one. If I did it properly, I addressed all comments made on this issue. |
|
Besides the little duplication above, it LGTM. |
|
👍 |
|
@fhemberger Fixed that. Merging. |
Added the Contribution Guidelines to CONTRIBUTING.md, with sections Code, Pull Requests, and Off-topic.