Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

os.cpus() can still report negative times in 0.10.x+ #5732

Closed
brycebaril opened this issue Jun 21, 2013 · 1 comment
Closed

os.cpus() can still report negative times in 0.10.x+ #5732

brycebaril opened this issue Jun 21, 2013 · 1 comment

Comments

@brycebaril
Copy link

This patch 50e88d0 was put in to fix this in 0.8.17, but it doesn't appear to have made it into 0.10+

node 0.8.24

node -e 'console.log(process.versions); console.log(require("os").cpus())'
{ http_parser: '1.0',
  node: '0.8.24',
  v8: '3.11.10.25',
  ares: '1.7.5-DEV',
  uv: '0.8',
  zlib: '1.2.3',
  openssl: '1.0.0f' }
[ { model: 'Intel(R) Core(TM) i7-2620M CPU @ 2.70GHz',
    speed: 800,
    times:
     { user: 282469100,
       nice: 2188700,
       sys: 244357000,
       idle: 23394966500,
       irq: 13000 } },
  { model: 'Intel(R) Core(TM) i7-2620M CPU @ 2.70GHz',
    speed: 800,
    times:
     { user: 186804900,
       nice: 825600,
       sys: 200051100,
       idle: 23657497100,
       irq: 0 } },
  { model: 'Intel(R) Core(TM) i7-2620M CPU @ 2.70GHz',
    speed: 800,
    times:
     { user: 249000600,
       nice: 1541100,
       sys: 254606300,
       idle: 23486375100,
       irq: 3900 } },
  { model: 'Intel(R) Core(TM) i7-2620M CPU @ 2.70GHz',
    speed: 2701,
    times:
     { user: 187966000,
       nice: 857000,
       sys: 188466600,
       idle: 23657220800,
       irq: 0 } } ]

node 0.10.12 (0.10.0+)

node -e 'console.log(process.versions); console.log(require("os").cpus())'
{ http_parser: '1.0',
  node: '0.10.12',
  v8: '3.14.5.9',
  ares: '1.9.0-DEV',
  uv: '0.10.11',
  zlib: '1.2.3',
  modules: '11',
  openssl: '1.0.1e' }
[ { model: 'Intel(R) Core(TM) i7-2620M CPU @ 2.70GHz',
    speed: 2701,
    times:
     { user: 282433500,
       nice: 2188500,
       sys: 244339700,
       idle: 1917370920,
       irq: 13000 } },
  { model: 'Intel(R) Core(TM) i7-2620M CPU @ 2.70GHz',
    speed: 800,
    times:
     { user: 186780700,
       nice: 825600,
       sys: 200042700,
       idle: -2115098176,
       irq: 0 } },
  { model: 'Intel(R) Core(TM) i7-2620M CPU @ 2.70GHz',
    speed: 800,
    times:
     { user: 248971500,
       nice: 1541000,
       sys: 254592500,
       idle: 2008763020,
       irq: 3900 } },
  { model: 'Intel(R) Core(TM) i7-2620M CPU @ 2.70GHz',
    speed: 800,
    times:
     { user: 187941900,
       nice: 857000,
       sys: 188459200,
       idle: -2115375276,
       irq: 0 } } ]
bnoordhuis added a commit that referenced this issue Jul 23, 2013
The return values from uv_cpu_info() don't necessarily fit in a 32 bits
signed integer.

Fixes #5732.
@bnoordhuis
Copy link
Member

Thanks, fixed in e20811a.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants