Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: sort internal binding list #24292

Merged
merged 1 commit into from
Nov 13, 2018
Merged

src: sort internal binding list #24292

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 16 additions & 16 deletions lib/internal/bootstrap/loaders.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,31 +75,31 @@
// to provide a transition path for modules that are being moved over to
// internalBinding.
const internalBindingWhitelist = [
'async_wrap',
'buffer',
'cares_wrap',
'constants',
'contextify',
'crypto',
'fs_event_wrap',
'http_parser',
'icu',
'udp_wrap',
'uv',
'js_stream',
'natives',
'pipe_wrap',
'http_parser',
'process_wrap',
'v8',
'tty_wrap',
'stream_wrap',
'signal_wrap',
'crypto',
'contextify',
'spawn_sync',
'stream_wrap',
'tcp_wrap',
'tls_wrap',
'util',
'async_wrap',
'tty_wrap',
'udp_wrap',
'url',
'spawn_sync',
'js_stream',
'zlib',
'buffer',
'natives',
'constants'
'util',
'uv',
'v8',
'zlib'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it be possible to put a trailing comma here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possible, yes. But we don't currently have anything that would come after zlib.

];
// We will use a lazy loaded SafeSet in internalBindingWhitelistHas
// for checking existence in this list.
Expand Down