assert: loose deep equal should not compare symbol properties #27653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the way it's currently documented and that seems appropriate for loose equal assertions. The change was not intentional. Fixes: nodejs#27652
nodejs-github-bot
added
the
util
targos
approved these changes
May 11, 2019
addaleax
approved these changes
May 11, 2019
Trott
approved these changes
May 12, 2019
Trott
added
the
author ready
ZYSzys
approved these changes
May 12, 2019
|
Landed in 3aff264 |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
May 13, 2019
This is the way it's currently documented and that seems appropriate for loose equal assertions. The change was not intentional. Fixes: nodejs#27652 PR-URL: nodejs#27653 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]>
targos
pushed a commit
that referenced
this pull request
May 14, 2019
This is the way it's currently documented and that seems appropriate for loose equal assertions. The change was not intentional. Fixes: #27652 PR-URL: #27653 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the way it's currently documented and that seems appropriate
for loose equal assertions. The change was not intentional.
Fixes: #27652
// cc @nodejs/assert
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes