Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: sort references lexically #34848

Closed
wants to merge 0 commits into from
Closed

doc: sort references lexically #34848

wants to merge 0 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Aug 20, 2020

Keep references sorted in ASCII order in module.md.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. module Issues and PRs related to the module subsystem. labels Aug 20, 2020
@Trott
Copy link
Member Author

Trott commented Aug 20, 2020

@nodejs/documentation

@jasnell jasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Aug 20, 2020
@jasnell
Copy link
Member

jasnell commented Aug 20, 2020

Fast-track? Please 👍🏻

@jasnell jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 20, 2020
@Trott
Copy link
Member Author

Trott commented Aug 20, 2020

Landed in 9d81d12

Trott added a commit that referenced this pull request Aug 20, 2020
@Trott
doc: sort references lexically
9d81d12 
Keep references sorted in ASCII order in module.md.

PR-URL: #34848
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ricky Zhou <[email protected]>
@Trott Trott closed this Aug 20, 2020
@Trott Trott deleted the lexical branch August 20, 2020 17:27
BethGriggs pushed a commit that referenced this pull request Aug 24, 2020
@Trott @BethGriggs
doc: sort references lexically
ef41ddf 
Keep references sorted in ASCII order in module.md.

PR-URL: #34848
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ricky Zhou <[email protected]>
@danielleadams danielleadams mentioned this pull request Aug 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@watilde watilde watilde approved these changes

@aymen94 aymen94 aymen94 approved these changes

@rickyes rickyes rickyes approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. module Issues and PRs related to the module subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Trott @jasnell @watilde @aymen94 @rickyes @nodejs-github-bot