Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix a typo of microtaskMode #34980

Closed
wants to merge 1 commit into from
Closed

doc: fix a typo of microtaskMode #34980

wants to merge 1 commit into from

Conversation

shigma
Copy link
Contributor

@shigma shigma commented Aug 30, 2020 

- tasks scheduled through `Promise`s any `async function`s
+ tasks scheduled through `Promise`s and `async function`s
Checklist

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. vm Issues and PRs related to the vm subsystem. labels Aug 30, 2020
@addaleax addaleax added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 5, 2020
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 5, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2020

Landed in 4cca942

nodejs-github-bot pushed a commit that referenced this pull request Sep 5, 2020
@shigma @nodejs-github-bot
doc: fix a typo of microtaskMode
4cca942 
PR-URL: #34980
Reviewed-By: Derek Lewis <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@github-actions github-actions bot closed this Sep 5, 2020
richardlau pushed a commit that referenced this pull request Sep 7, 2020
@shigma @richardlau
doc: fix a typo of microtaskMode
199bc36 
PR-URL: #34980
Reviewed-By: Derek Lewis <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@richardlau richardlau mentioned this pull request Sep 7, 2020
Merged
4 tasks
richardlau pushed a commit that referenced this pull request Sep 7, 2020
@shigma @richardlau
doc: fix a typo of microtaskMode
c3a3cb6 
PR-URL: #34980
Reviewed-By: Derek Lewis <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@shigma @joesepi
doc: fix a typo of microtaskMode
527e557 
PR-URL: nodejs#34980
Reviewed-By: Derek Lewis <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@shigma shigma deleted the patch-1 branch March 28, 2021 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@lpinca lpinca lpinca approved these changes

@DerekNonGeneric DerekNonGeneric DerekNonGeneric approved these changes

@HarshithaKP HarshithaKP HarshithaKP approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. vm Issues and PRs related to the vm subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@shigma @Trott @lpinca @DerekNonGeneric @HarshithaKP @addaleax @nodejs-github-bot