Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update backport requirements on LTS lines #35058

Closed
wants to merge 1 commit into from

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Sep 4, 2020

Refs: #34950 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

cc\ @richardlau @jkrems

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 4, 2020
@jkrems
Copy link
Contributor

jkrems commented Sep 4, 2020

Thanks for keeping these in sync with practices! But I think what should have happened here that the back port requested label should either not have been added or removed (if it was active while the version moved into maintenance mode).

Maybe it would be better to make it two sentences, the latter being something along the lines "backports for feature additions shouldn't be requested for maintenance versions"?

@BethGriggs
Copy link
Member

Yes, the label was added when v10.x was still in Active LTS. (It looks like we still have 131 with that label.)

Adding release-agenda so we can discuss in our next Release WG meeting. I do think we need some process around auditing/removing backport-requested-vN.x labels when a release line transitions from Active LTS to Maintenance.
/cc @nodejs/release

@BethGriggs BethGriggs added the release-agenda Issues and PRs to discuss during the meetings of the Release team. label Sep 5, 2020
@BethGriggs
Copy link
Member

We discussed this in the Release WG meeting last week (nodejs/Release#609) and agreed that we should delete the backport-requested-vN.x label when a release transitions between Active LTS and Maintenance. #35224 updates our documentation to include this.

@aduh95
Copy link
Contributor Author

aduh95 commented Sep 18, 2020

@BethGriggs #35224 has landed, should I close this?

@BethGriggs
Copy link
Member

@aduh95 I think so, yes

@aduh95 aduh95 closed this Sep 19, 2020
@aduh95 aduh95 deleted the fix-backporting-rules branch July 16, 2022 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. release-agenda Issues and PRs to discuss during the meetings of the Release team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants