Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timers: add non-boolean ref test setImmediate #35860

Conversation

RaisinTen
Copy link
Contributor

I added a test to improve the coverage here:

if (typeof ref !== 'boolean') {
return PromiseReject(
new ERR_INVALID_ARG_TYPE(
'options.ref',
'boolean',
ref));
}

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 29, 2020
@Trott
Copy link
Member

Trott commented Oct 29, 2020

LGTM but I think it's a duplicate of #35852.

@RaisinTen
Copy link
Contributor Author

@Trott 🤦 I forgot to check before I made the PR. Whoops! Should I close it?

@Trott
Copy link
Member

Trott commented Oct 29, 2020

@Trott 🤦 I forgot to check before I made the PR. Whoops! Should I close it?

In this case, yeah, probably.

@RaisinTen RaisinTen closed this Oct 29, 2020
@RaisinTen RaisinTen deleted the timers/add-non-boolean-ref-test-setImmediate branch October 29, 2020 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants