Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: remove checkIP options argument #41571

Closed
wants to merge 1 commit into from
Closed

crypto: remove checkIP options argument #41571

wants to merge 1 commit into from

Conversation

tniessen
Copy link
Member

None of the supported options have any effect on X509_check_ip_asc.

(iPAddress is not a typo, it is what RFC 5280 calls subject alternative names that are IP addresses.)

Refs: openssl/openssl#17536

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto

@tniessen tniessen requested a review from jasnell January 17, 2022 16:07
@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Jan 17, 2022
@tniessen tniessen added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 17, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 17, 2022
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
lpinca
lpinca approved these changes Jan 17, 2022
View reviewed changes
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@tniessen tniessen changed the title tls: remove checkIP options argument crypto: remove checkIP options argument Jan 17, 2022
@tniessen tniessen added the tls Issues and PRs related to the tls subsystem. label Jan 17, 2022
@tniessen tniessen force-pushed the tls-remove-x509-checkip-options branch from 30b034c to fe6b397 Compare January 17, 2022 20:53
@tniessen
Copy link
Member Author

@lpinca I've rephrased it in the hope that it will be clearer. If it isn't, I'm happy to go with your suggestion and dropping all RFC-specific terminology.

@tniessen tniessen added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 17, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 17, 2022
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@github-actions github-actions bot mentioned this pull request Jan 18, 2022
Open
16 tasks
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@github-actions github-actions bot mentioned this pull request Jan 19, 2022
Open
13 tasks
@tniessen
crypto: remove checkIP options argument
431a70a 
None of the supported options have any effect on X509_check_ip_asc.

Refs: openssl/openssl#17536
@tniessen tniessen force-pushed the tls-remove-x509-checkip-options branch from fe6b397 to 431a70a Compare January 19, 2022 15:47
@tniessen tniessen added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 19, 2022
@tniessen
Copy link
Member Author

Rebased due to #41569.

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 19, 2022
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/42026/

@tniessen
Copy link
Member Author

Landed in 6d66649, thanks for reviewing.

@tniessen tniessen closed this Jan 19, 2022
tniessen added a commit that referenced this pull request Jan 19, 2022
@tniessen
crypto: remove checkIP options argument
6d66649 
None of the supported options have any effect on X509_check_ip_asc.

Refs: openssl/openssl#17536

PR-URL: #41571
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
tniessen added a commit to tniessen/node that referenced this pull request Jan 19, 2022
@tniessen
crypto: remove wildcard options for checkEmail
971e41f 
Wildcard options do not affect X509_check_email.

Refs: openssl/openssl#17536
Refs: nodejs#41571
@tniessen tniessen mentioned this pull request Jan 19, 2022
Closed
This was referenced Jan 20, 2022
Open
Open
Open
panva pushed a commit that referenced this pull request Jan 22, 2022
@tniessen @panva
crypto: remove wildcard options for checkEmail
5aa4010 
Wildcard options do not affect X509_check_email.

Refs: openssl/openssl#17536
Refs: #41571

PR-URL: #41599
Reviewed-By: Tierney Cyren <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
This was referenced Jan 23, 2022
Open
Open
BethGriggs pushed a commit that referenced this pull request Jan 25, 2022
@tniessen @BethGriggs
crypto: remove checkIP options argument
b43faf0 
None of the supported options have any effect on X509_check_ip_asc.

Refs: openssl/openssl#17536

PR-URL: #41571
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
BethGriggs pushed a commit that referenced this pull request Jan 25, 2022
@tniessen @BethGriggs
crypto: remove wildcard options for checkEmail
9e39e62 
Wildcard options do not affect X509_check_email.

Refs: openssl/openssl#17536
Refs: #41571

PR-URL: #41599
Reviewed-By: Tierney Cyren <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
@tniessen @Linkgoron
crypto: remove checkIP options argument
d10d3c0 
None of the supported options have any effect on X509_check_ip_asc.

Refs: openssl/openssl#17536

PR-URL: nodejs#41571
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
@tniessen @Linkgoron
crypto: remove wildcard options for checkEmail
900128f 
Wildcard options do not affect X509_check_email.

Refs: openssl/openssl#17536
Refs: nodejs#41571

PR-URL: nodejs#41599
Reviewed-By: Tierney Cyren <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Feb 8, 2022
Merged
danielleadams pushed a commit that referenced this pull request Feb 28, 2022
@tniessen @danielleadams
crypto: remove checkIP options argument
e464990 
None of the supported options have any effect on X509_check_ip_asc.

Refs: openssl/openssl#17536

PR-URL: #41571
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit that referenced this pull request Feb 28, 2022
@tniessen @danielleadams
crypto: remove wildcard options for checkEmail
2a46a67 
Wildcard options do not affect X509_check_email.

Refs: openssl/openssl#17536
Refs: #41571

PR-URL: #41599
Reviewed-By: Tierney Cyren <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 2, 2022
@tniessen @danielleadams
crypto: remove checkIP options argument
a9455c4 
None of the supported options have any effect on X509_check_ip_asc.

Refs: openssl/openssl#17536

PR-URL: #41571
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 2, 2022
@tniessen @danielleadams
crypto: remove wildcard options for checkEmail
c3e20a4 
Wildcard options do not affect X509_check_email.

Refs: openssl/openssl#17536
Refs: #41571

PR-URL: #41599
Reviewed-By: Tierney Cyren <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
@danielleadams danielleadams mentioned this pull request Mar 3, 2022
Merged
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
@tniessen @danielleadams
crypto: remove checkIP options argument
86e3553 
None of the supported options have any effect on X509_check_ip_asc.

Refs: openssl/openssl#17536

PR-URL: #41571
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
@tniessen @danielleadams
crypto: remove wildcard options for checkEmail
26cd8b3 
Wildcard options do not affect X509_check_email.

Refs: openssl/openssl#17536
Refs: #41571

PR-URL: #41599
Reviewed-By: Tierney Cyren <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
@tniessen @danielleadams
crypto: remove checkIP options argument
1ef28f1 
None of the supported options have any effect on X509_check_ip_asc.

Refs: openssl/openssl#17536

PR-URL: #41571
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
@tniessen @danielleadams
crypto: remove wildcard options for checkEmail
fe0f9dc 
Wildcard options do not affect X509_check_email.

Refs: openssl/openssl#17536
Refs: #41571

PR-URL: #41599
Reviewed-By: Tierney Cyren <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tniessen @nodejs-github-bot @jasnell @lpinca @cjihrig