esm: refactor get_format
#53872
Merged
esm: refactor get_format
#53872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
esm
GeoffreyBooth
approved these changes
Jul 16, 2024
ShogunPanda
approved these changes
Jul 17, 2024
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
aduh95
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in cafd44d |
ehsankhfr
pushed a commit
to ehsankhfr/node
that referenced
this pull request
Jul 18, 2024
PR-URL: nodejs#53872 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jul 28, 2024
PR-URL: #53872 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Merged
targos
added
the
dont-land-on-v20.x
joyeecheung
pushed a commit
to joyeecheung/node
that referenced
this pull request
Feb 4, 2025
PR-URL: nodejs#53872 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
joyeecheung
pushed a commit
to joyeecheung/node
that referenced
this pull request
Feb 5, 2025
PR-URL: nodejs#53872 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
joyeecheung
pushed a commit
to joyeecheung/node
that referenced
this pull request
Feb 5, 2025
PR-URL: nodejs#53872 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
|
Backport in #56927 |
joyeecheung
added
backport-open-v20.x
joyeecheung
pushed a commit
to joyeecheung/node
that referenced
this pull request
Feb 6, 2025
PR-URL: nodejs#53872 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
joyeecheung
pushed a commit
to joyeecheung/node
that referenced
this pull request
Feb 6, 2025
PR-URL: nodejs#53872 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
joyeecheung
pushed a commit
to joyeecheung/node
that referenced
this pull request
Feb 10, 2025
PR-URL: nodejs#53872 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
marco-ippolito
pushed a commit
that referenced
this pull request
Feb 11, 2025
PR-URL: #53872 Backport-PR-URL: #56927 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Refs: #52697
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from aadf162