Add Korean translations #28
Conversation
|
@marocchino Can you get someone from @iojs/iojs-ko to +1 this? |
|
@bnb It still working, I will request review later. 🙇 |
|
Okey, done. @iojs/iojs-ko , @yous review please. |
| @@ -160,7 +162,7 @@ | |||
| <li>io.js will take responsibility for old versions of dependencies like V8 that appear in prior releases when their maintainers stop supporting them.</li> | |||
| </ul> | |||
| <br> | |||
| <p class="note">Summary from <a href="https://github.com/iojs/io.js/blob/v1.x/ROADMAP.md">Stability Policy</a>. Contributors welcome!</p> | |||
| <p class="note">Summary from <a href="https://github.com/iojs/io.js/blob/v1.x/ROADMAP.md">Long Term Support</a>. Contributors welcome!</p> | |||
There was a problem hiding this comment.
Actually 'Stability Policy' heading is <h2> and 'Long Term Support' heading is <h3>. Is there any reason to change this?
There was a problem hiding this comment.
I thought It's miss duplicated from L94 and it is more reasonable match with slide title.
Maybe, It needs to confirm from admin.
There was a problem hiding this comment.
To be fair, you're both technically correct (not, however, for the reason you assumed, @marocchino), as this slide pulls from both the Stability Policy and the Long Term Support sections of the ROADMAP.md on iojs/io.js. I would say leave it as it was (Stability Policy), for two reasons:
- Two of the three points in this slide are from the Stability Policy section of the ROADMAP.md, and one is from the Long Term Support section
- The Stability is directly above the LTS section in ROADMAP.md, so it makes sense in terms of order to credit it to Stability, as the reader will naturally flow from Stability to LTS.
That said, this is something to consider changing to make more clear and/or 100% accurate. Neither of you are wrong. But I would say the best course of action is to leave the Stability Policy text as is. /ping @mikeal
| <h2>커뮤니티를 위한, 커뮤니티에 의한</h2> | ||
| <p><strong>io.js</strong>는 Node.js의 대용품이며 <strong>npm</strong>에 있는 npm의 거의 모든 모듈과 호환된다. | ||
| </p> | ||
| <p><strong>io.js</strong>는 커뮤니티 주도의 오픈소스 프로젝트이다. io.js는 node.js의 주요 컨트리뷰터로 시작했지만, 이미 node.js의 모든 기록을 뛰어넘는 더 많은 active 개발자를 모집했다.</p> |
There was a problem hiding this comment.
컨트리뷰터 → 기여자
active → 활발한
이미 node.js의 모든 기록을 뛰어넘는 더 많은 active 개발자를 모집했다.
For the 'in the first few months', maybe we should change the term '이미' to '불과 몇 개월 만에'. We could say '불과 몇 개월 만에 node.js 역사상 가장 많은 수의 활발한 개발자를 모집했다.'.
| <li>JS API를 제거하지 않는다.</li> | ||
| <li><a href="http://semver.org/lang/ko/">유의적 버전</a> | ||
| <ul> | ||
| <li>어떤 API 추가도 <em>minor</em> 버전을 증가시킨다.</li> |
There was a problem hiding this comment.
We can use '부버전' used in http://semver.org/lang/ko/, otherwise just '마이너 버전' can be used.
어떤 API 추가도 minor 버전을 증가시킨다.
Seeing http://semver.org/lang/ko/, we could say 'API를 추가할 때는 minor 버전을 올린다.'. If you want to emphasize 'any', '어떤 API를 추가하더라도 minor 버전을 올린다.' also can be used, but I like the former one.
marocchino
force-pushed
the
korean
branch
5 times, most recently
from
ece30c8 to
67a38bd
Compare
|
Reviews in 71bcf2b also appled. |
|
My review is done. 👍 |
|
Also I'm done. |
|
@bnb Review is over. Just check the "summary" part, please. Should I revert it? |
|
@mikeal ping! |
|
@marocchino In the future, leave changes to the English files in their own PRs, and translation changes in their own PRs. It's much easier to track the changes that way. |
|
@bnb Okey. I reverted it. |
|
Is this ready? Can you add this to the list of to the list of available translations in the index. |
|
@mikeal did it. :) |
No description provided.