Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backpressure algorithm flaky test #23

Closed
ronag opened this issue May 2, 2020 · 1 comment
Closed

backpressure algorithm flaky test #23

ronag opened this issue May 2, 2020 · 1 comment
Labels
Status: help-wanted This issue/pr is open for contributions

Comments

@ronag
Copy link
Member

ronag commented May 2, 2020 

 ✖ should not be equal

  test/pool.js                                    
  106 |                                           
  107 |   t.strictEqual(d3.client, d2.client)     
> 108 |   t.notStrictEqual(d3.client, d4.client)  
      | ----^                                     
  109 |                                           
  110 |   d3.client.emit('drain')                 
  111 |
@ronag
Copy link
Member Author

ronag commented May 4, 2020

I haven't gotten to the pool yet, will finish up the stuff I can find on client first before looking at this.

@ronag ronag added the Status: help-wanted This issue/pr is open for contributions label May 5, 2020
ronag added a commit to nxtedition/undici that referenced this issue May 13, 2020
@ronag
fix: pool should be depth first connected
1c1aef6 
Fixes: nodejs#69
Fixes: nodejs#23
@ronag ronag closed this as completed in d52b1ca May 13, 2020
@snyk-bot snyk-bot mentioned this issue Sep 15, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: help-wanted This issue/pr is open for contributions
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ronag