fix: broken assertion #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Haven't been able to trigger this in practice, but in theory it was a problem. |
ronag
commented
May 11, 2020
finished will be invoked on 'end' while destroy(err) will be delayed. This can break the assertion in theory on edge cases.
ronag
commented
May 11, 2020
| @@ -197,10 +197,10 @@ function _connect (client) { | |||
| client[kQueue].pause() | |||
|
|
|||
| client[kStream].finished(socket, (err) => { | |||
There was a problem hiding this comment.
The actual behavior of how and when this is invoked, with or without error is a slightly dependent on node/readable-stream version. This is a safer way to implement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
finished will be invoked on 'end' while destroy(err) will be delayed.
This can break the assertion in theory on edge cases.