Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't resume while piping request #105

Merged
merged 5 commits into from
May 12, 2020
Merged

fix: don't resume while piping request #105

merged 5 commits into from
May 12, 2020

Conversation

ronag
Copy link
Member

@ronag ronag commented May 12, 2020

No description provided.

mcollina
mcollina requested changes May 12, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you avoid the setTimeout in the tests and use setImmediate instead?

@ronag
Copy link
Member Author

ronag commented May 12, 2020

Fixed

mcollina
mcollina reviewed May 12, 2020
View reviewed changes
mcollina
mcollina approved these changes May 12, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ronag ronag merged commit 8a340f1 into nodejs:master May 12, 2020
@ronag ronag deleted the fixes3 branch May 12, 2020 18:53
@snyk-bot snyk-bot mentioned this pull request Jul 14, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ronag @mcollina