Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

using-node-with-framework #83

Closed

Conversation

ipongrani
Copy link

testing

@keywordnew
Copy link
Contributor

keywordnew commented Aug 18, 2018

Thank you for opening the PR! 🎉

I'd recommend:

  • Adding the related issue to the body of the opening comment, that is #60, for people to understand the context
  • A descriptive PR title would also help people understand the purpose of this PR

An helpful example reference of a PR would be #84.

@keywordnew
Copy link
Contributor

@ipongrani I'm happy to help guide you while you make this PR.

A getting started guide of this type would be easier (and more useful too!) to write if it focused on just one framework.

For example, "Using Node.js with React" or "Using Node.js with Vuejs"

@amiller-gh amiller-gh mentioned this pull request Sep 13, 2018
7 tasks
@ipongrani
Copy link
Author

ipongrani commented Sep 14, 2018 via email

Copy link
Contributor

@codeekage codeekage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO I think the front-end framework as the file name is kinda too generic, since this deals with just React. Maybe something like node-with-react-frontend-framework.


### Requirements:
- Node.js
- React.js

- NPM (package manager)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm with lower caps


> assuming you have already learned about NPM on the previous section of the documentation, We will continue with using NPM to install CRA(create-react-app).
> We will continue by using NPM to install CRA(create-react-app).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm here too

@Trott
Copy link
Member

Trott commented Apr 22, 2023

I've unarchived this repo so I can close all PRs and issues before re-archiving.

@Trott Trott closed this Apr 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
getting-started-docs Getting started documentation page
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants