Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement Request: downsample to the maximum of either the file event count or target #89

Open
tjchen opened this issue Mar 2, 2014 · 2 comments
Assignees
Labels

Comments

@tjchen
Copy link
Collaborator

tjchen commented Mar 2, 2014

in downsample.R please give the option of downsampling to the maximum of either the file event count or target. Currently it is a hard threshold on the event count and fails if the number of events in the file are less than the downsampling event number.

@esimonds
Copy link
Collaborator

esimonds commented Mar 2, 2014

Good idea. While we're mucking around I there, is support for "percent" of
cell events currently supported in Driver.R? (note that I'm not talking
about "percentile of density"). It's the default on Cytobank SPADE but I
suspect it was an improvement on their end.

On Saturday, March 1, 2014, TJ Chen [email protected] wrote:

in downsample.R please give the option of downsampling to the maximum of
either the file event count or target. Currently it is a hard threshold on
the event count and fails if the number of events in the file are less than
the downsampling event number.

Reply to this email directly or view it on GitHubhttps://github.com//issues/89
.

@zbjornson
Copy link
Collaborator

@esimonds yep, it's there:

(... in driver.r...)
downsampling_target_number=NULL,
downsampling_target_pctile=NULL,
downsampling_target_percent=0.1,
(...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants