Presigned URL - Expiry limit from milliseconds to seconds and epoch fixes + automatic tests #8503
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
In #8493 changes there were 2 issues -
const expiry_seconds = req.query.Expires - Math.ceil(Date.now() / 1000);
in order to compare the limit on epoch case correctly.Issues: Fixed #xxx / Gap #xxx
Testing Instructions:
sudo NC_CORETEST=true node ./node_modules/mocha/bin/mocha /github/noobaa-core/src/test/unit_tests/test_bucketspace.js -g 'Presigned URL tests'