Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add contributor ladder #75

Merged
merged 5 commits into from
Jun 4, 2024

Conversation

yizha1
Copy link
Contributor

@yizha1 yizha1 commented Apr 13, 2024

Resolve #15

Signed-off-by: Yi Zha [email protected]

Signed-off-by: Yi Zha (from Dev Box) <[email protected]>
Signed-off-by: Yi Zha (from Dev Box) <[email protected]>
toddysm
toddysm previously approved these changes Apr 24, 2024
Signed-off-by: Yi Zha <[email protected]>
@yizha1
Copy link
Contributor Author

yizha1 commented May 21, 2024

Would you mind reviewing this PR again @notaryproject/notaryproject-governance-maintainers?

@kipz and @whalelines your comments are also welcome.

Copy link

@whalelines whalelines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple comments

Signed-off-by: Yi Zha <[email protected]>
@yizha1 yizha1 requested a review from whalelines May 23, 2024 08:29
@yizha1
Copy link
Contributor Author

yizha1 commented May 23, 2024

Thanks @whalelines and @shizhMSFT for comments. Please review this PR again.

Copy link

@kipz kipz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Yi Zha <[email protected]>
@yizha1 yizha1 requested a review from shizhMSFT May 24, 2024 07:17
Copy link

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@vaninrao10 vaninrao10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yizha1 yizha1 merged commit 308342e into notaryproject:main Jun 4, 2024
1 check passed
@yizha1 yizha1 deleted the contributor_ladder branch June 4, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Contributor ladder document for each sub-project
7 participants