Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: migrate two guides from notation repo and update notatation-config-file.md #80

Merged
merged 15 commits into from
Nov 10, 2022
Merged

doc: migrate two guides from notation repo and update notatation-config-file.md #80

merged 15 commits into from
Nov 10, 2022

Conversation

FeynmanZhou
Copy link
Member

Fix notaryproject/notation#191

Signed-off-by: Feynman Zhou [email protected]

@netlify
Copy link

netlify bot commented Oct 28, 2022 •
edited
Loading

✅ Deploy Preview for notarydev ready!

Name Link
🔨 Latest commit 8ab7448
🔍 Latest deploy log https://app.netlify.com/sites/notarydev/deploys/636d11dc7ce5550008a2a2fc
😎 Deploy Preview https://deploy-preview-80--notarydev.netlify.app/docs/quickstart
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@FeynmanZhou FeynmanZhou requested review from dtzar and yizha1 October 28, 2022 04:21
@FeynmanZhou FeynmanZhou changed the title migrate two guides from notation repo to the website and update notat… migrate two guides from notation repo and update notatation-config-file.md Oct 28, 2022
@FeynmanZhou FeynmanZhou changed the title migrate two guides from notation repo and update notatation-config-file.md doc: migrate two guides from notation repo and update notatation-config-file.md Oct 28, 2022
@FeynmanZhou FeynmanZhou mentioned this pull request Oct 28, 2022
Closed
@dtzar
Copy link
Contributor

dtzar commented Nov 2, 2022

LGTM I'd just fix issues JeyJeyGao calls out and we can approve/merge.

@FeynmanZhou FeynmanZhou mentioned this pull request Nov 3, 2022
Closed
@FeynmanZhou FeynmanZhou requested a review from JeyJeyGao November 6, 2022 11:55
@FeynmanZhou FeynmanZhou requested a review from shizhMSFT November 8, 2022 09:53
JeyJeyGao
JeyJeyGao reviewed Nov 8, 2022
View reviewed changes
JeyJeyGao
JeyJeyGao previously approved these changes Nov 8, 2022
View reviewed changes
Copy link

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shizhMSFT
shizhMSFT reviewed Nov 9, 2022
View reviewed changes
dtzar
dtzar previously approved these changes Nov 9, 2022
View reviewed changes
@FeynmanZhou
fix conflicts
8ab7448 
Signed-off-by: Feynman Zhou <[email protected]>
@zr-msft zr-msft mentioned this pull request Nov 10, 2022
Closed
@dtzar dtzar merged commit da3b5c1 into notaryproject:main Nov 10, 2022
@FeynmanZhou
Copy link
Member Author

I will submit a PR to remove the duplicated guides in https://github.com/notaryproject/notation/tree/main/specs

@toddysm toddysm mentioned this pull request Feb 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtzar dtzar dtzar approved these changes

@JeyJeyGao JeyJeyGao JeyJeyGao left review comments

@yizha1 yizha1 Awaiting requested review from yizha1 yizha1 is a code owner

@shizhMSFT shizhMSFT Awaiting requested review from shizhMSFT shizhMSFT is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Plugin config directory varies based on OS and should be clearer with docs
4 participants
@FeynmanZhou @dtzar @shizhMSFT @JeyJeyGao