-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup Hugo site with Docsy Theme #9
Conversation
✔️ Deploy Preview for notarydev ready! 🔨 Explore the source changes: 8b24c05 🔍 Inspect the deploy log: https://app.netlify.com/sites/notarydev/deploys/6115802ad953cb000784c850 😎 Browse the preview: https://deploy-preview-9--notarydev.netlify.app |
/cc @lachie83 |
Link checker failed... I'll disable it for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, maybe you didn't start from the latest version of etcd.io? For example, this PR contains check-hugo.sh
.
version_menu: Versions | ||
versions: | ||
latest: v2 | ||
all: | ||
- v2 | ||
- v1 | ||
deprecation_warning: |- | ||
the documentation is no longer actively maintained. | ||
The page that you are viewing is the last archived version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wish that we had cleaned this up first. Maybe we can do the cleanup in this repo and back port a solution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I opened a PR a little bit ago that looks at doing some of that cleanup: etcd-io/website#354
content/en/about.md
Outdated
--- | ||
title: About | ||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure that you want an about page? If not, drop this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'll keep it in for now, and have a discussion with the maintainers about it.
I've been looking at the issues/PRs list and can't find the discussion we had with the rationale behind cutting it. I remember agreeing, but it'd be good to link the issue. Do you recall where we had the conversation, @chalin?
For context, @SteveLasker, the whole site is basically about the project, so a specific about page can be a bit redundant (I know I've included an about in the docs assessment IA, but included it as a placeholder for discussion--I should be more clear about that in the assessment itself).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI: etcd-io/website#434 :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll need to get the latest etcd.io files. In particular, we don't want the version of render-link.html
that is currently in this PR.
For details, see inlined comments.
I think you're right -- I'm disappointed that I missed this. I'd been working between two computers and think I did it on one but had to redo some work on the other. I'll apply your suggestions and try to do a diff and bring this repo up to speed. Thanks for catching it! |
This is new, I like that the Netlify bot now provides an info comment (with a deploy preview) |
b2a7a6f
to
db28187
Compare
I've re-enabled it in the latest commit. |
db28187
to
6dd86a1
Compare
@SteveLasker, in the footer I have the copyright line:
I doubt this is the correct date range, do you know which year we should use as the start date here? |
68237a7
to
9485309
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd drop the About page now (it is harder to remove things once they're introduced). Other than that, and the minor inlined comments, LGTM.
…o/website. Signed-off-by: Nate W <[email protected]>
9485309
to
8b24c05
Compare
Thanks for the feedback @chalin, I appreciate it! |
Closes #5, #10
First pass at notaryproject.dev - cloning etcd-io/website.
Deploy preview: https://deploy-preview-9--notarydev.netlify.app/