Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[revocation] Implement OCSP support #124

Closed
priteshbandi opened this issue Feb 28, 2023 · 3 comments
Closed

[revocation] Implement OCSP support #124

priteshbandi opened this issue Feb 28, 2023 · 3 comments

Comments

@priteshbandi
Copy link
Contributor

Spec: https://github.com/notaryproject/notaryproject/blob/main/specs/trust-store-trust-policy.md#ocsp
@priteshbandi priteshbandi changed the title Implement OCSP revocation validation [revocation] Implement OCSP validation Feb 28, 2023
@priteshbandi priteshbandi changed the title [revocation] Implement OCSP validation [revocation] Implement OCSP support Feb 28, 2023
This was referenced Feb 28, 2023
Closed
Open
@kody-kimberl kody-kimberl mentioned this issue Mar 11, 2023
Closed
@kody-kimberl kody-kimberl mentioned this issue Mar 21, 2023
Closed
@kody-kimberl
Copy link
Contributor

Proposed design: #132

This was referenced Mar 24, 2023
Merged
Merged
priteshbandi pushed a commit that referenced this issue Apr 20, 2023
@kody-kimberl
feat: adding OCSP revocation implementation (#134)
cefe2ef 
This PR adds a new package that will perform OCSP revocation checking for a certificate chain and addresses part of issue #124. Implementation is based on the design from #132 and the specification
[here](https://github.com/notaryproject/notaryproject/blob/main/specs/trust-store-trust-policy.md#certificate-revocation-evaluation).

Signed-off-by: Kody Kimberl <[email protected]>
priteshbandi pushed a commit to notaryproject/notation-go that referenced this issue Apr 20, 2023
@kody-kimberl
feat: adding OCSP revocation checks to Verify (#295)
3dd11cb 
This PR adds OCSP revocation checking to the Verify function using the notation-core-go's revocation package.
This PR addresses part of the following issue: notaryproject/notation-core-go#124. It is dependent on notaryproject/notation-core-go#134

Signed-off-by: Kody Kimberl <[email protected]>
Signed-off-by: Kody Kimberl <[email protected]>
@yizha1
Copy link
Contributor

yizha1 commented Apr 26, 2023

@priteshbandi @kody-kimberl Can we close this issue since PR were merged

@yizha1
Copy link
Contributor

yizha1 commented Sep 18, 2023

Closed as OCSP was implemented and released.

@yizha1 yizha1 closed this as completed Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@priteshbandi @kody-kimberl @yizha1