Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Docker Credential Helper configuration for Notation authentication #600

Closed
FeynmanZhou opened this issue Mar 25, 2023 · 1 comment · Fixed by #654
Closed

Simplify Docker Credential Helper configuration for Notation authentication #600

FeynmanZhou opened this issue Mar 25, 2023 · 1 comment · Fixed by #654
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@FeynmanZhou
Copy link
Member

FeynmanZhou commented Mar 25, 2023

What is the areas you would like to add the new feature to?

Notation CLI

Is your feature request related to a problem?

To achieve maximum compatibility with existing systems, docker credential helpers and its protocol are adopted as the credential helpers for Notation registry authentication.

It requires cumbersome steps to configure docker credential helpers when users log in to a registry. Users will encounter an authentication problem in Linux as follows if the Docker Credential Helper configuration is not configured or misconfigured:

Error: could not get the credentials store: failed to load config file, error: credentials store config was not set up

We need to simplify the authentication experience and remove dependency on Docker Credential Helper configuration.

What solution do you propose?

Integrate oras-credentials-go library to simplify this authentication experience and remove the dependency. This library will be able to read credentials from the Docker configuration file.

My expectation is that if there is Docker Hub registry credential stored in the Docker configuration file, users will be able to log in to Docker Hub without additional configuration and input username/password.

What alternatives have you considered?

No

Any additional context?

No response

@FeynmanZhou FeynmanZhou added enhancement New feature or request triage Need to triage labels Mar 25, 2023
@FeynmanZhou FeynmanZhou added the duplicate This issue or pull request already exists label Apr 4, 2023
@FeynmanZhou FeynmanZhou added this to the 1.0.0 milestone Apr 20, 2023
@FeynmanZhou FeynmanZhou changed the title Remove dependency on Docker Credential Helper configuration Simplify Docker Credential Helper configuration Apr 25, 2023
@FeynmanZhou FeynmanZhou changed the title Simplify Docker Credential Helper configuration Simplify Docker Credential Helper configuration for Notation authentication Apr 25, 2023
@yizha1 yizha1 removed duplicate This issue or pull request already exists triage Need to triage labels Apr 26, 2023
@yizha1 yizha1 moved this from Todo to In Progress in Notary Project Planning Board Apr 26, 2023
@yizha1 yizha1 moved this from In Progress to PR Review in Notary Project Planning Board May 18, 2023
@yizha1 yizha1 modified the milestones: 1.0.0, v1.0.0-rc.6 May 23, 2023
@yizha1
Copy link
Contributor

yizha1 commented May 23, 2023

update milestone to v1.0.0-rc.6 per discussion in community call on 5/23/2023

shizhMSFT pushed a commit that referenced this issue May 23, 2023
Resolves: #600 
Resolves: #637

---------

Signed-off-by: Sylvia Lei <[email protected]>
@github-project-automation github-project-automation bot moved this from PR Review to Done in Notary Project Planning Board May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants